Skip to content

[Data Forge] Add parser for ES flag#248536

Merged
justinkambic merged 3 commits intoelastic:mainfrom
justinkambic:improve-data-forge
Jan 13, 2026
Merged

[Data Forge] Add parser for ES flag#248536
justinkambic merged 3 commits intoelastic:mainfrom
justinkambic:improve-data-forge

Conversation

@justinkambic
Copy link
Contributor

Summary

I was utilizing Data Forge to create some fake data today, and the script continually crashed when I provided the --payload-size flag. After researching the script, I noted that we could include a parser for this flag to prevent the crash, the command worked with this change in place.

Testing

Example command:

# failed for me on main, works on this branch

NODE_OPTIONS="--max-old-space-size=8192" node x-pack/scripts/data_forge.js \
  --events-per-cycle 50 \
  --lookback now-2d \
  --dataset fake_stack \
  --payload-size 5000 \
  --concurrency 3

…function to ensure valid input. This change improves the robustness of the command-line interface.
@justinkambic justinkambic self-assigned this Jan 9, 2026
@justinkambic justinkambic added chore release_note:skip Skip the PR/issue when compiling release notes labels Jan 9, 2026
@justinkambic justinkambic requested a review from a team as a code owner January 9, 2026 20:14
@justinkambic justinkambic added backport:skip This PR does not require backporting v9.4.0 Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jan 9, 2026
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-obs-team (Team:actionable-obs)

@justinkambic justinkambic enabled auto-merge (squash) January 9, 2026 20:32
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / discover - group 1 Discover CSV Export Generate CSV: new search generates a large export

Metrics [docs]

✅ unchanged

History

cc @justinkambic

@justinkambic justinkambic merged commit e05c61b into elastic:main Jan 13, 2026
13 checks passed
smith pushed a commit to smith/kibana that referenced this pull request Jan 16, 2026
## Summary

I was utilizing Data Forge to create some fake data today, and the
script continually crashed when I provided the `--payload-size` flag.
After researching the script, I noted that we could include a parser for
this flag to prevent the crash, the command worked with this change in
place.

## Testing

Example command:

```bash
# failed for me on main, works on this branch

NODE_OPTIONS="--max-old-space-size=8192" node x-pack/scripts/data_forge.js \
  --events-per-cycle 50 \
  --lookback now-2d \
  --dataset fake_stack \
  --payload-size 5000 \
  --concurrency 3
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants