Skip to content

Comments

[Dashboard] Highlight focused panels in non-animated gradient border#248534

Merged
Zacqary merged 7 commits intoelastic:mainfrom
Zacqary:panel-focus-highlight
Jan 26, 2026
Merged

[Dashboard] Highlight focused panels in non-animated gradient border#248534
Zacqary merged 7 commits intoelastic:mainfrom
Zacqary:panel-focus-highlight

Conversation

@Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jan 9, 2026

Summary

Adds the gradient border from highlighted panels to focused panels, without the animation

Screenshot 2026-01-09 at 3 09 32 PM

@Zacqary Zacqary requested a review from a team as a code owner January 9, 2026 19:41
@Zacqary Zacqary added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:version Backport to applied version labels v9.4.0 labels Jan 9, 2026
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

borderRadius: euiTheme.border.radius.medium,
animation: `${borderSpinKeyframes} ${highlightAnimationDuration}ms ease-out`,
},
'&.dshDashboardGrid__item--highlighted:not(&.dshDashboardGrid__item--focused) .embPanel::before':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this :not selector disables the highlight animation when you create a panel and then immediately bring it into focus. Since the focusing border uses the same pseudo-element, and the highlight animation fades the opacity to 0, this created a jarring effect.

@Zacqary Zacqary enabled auto-merge (squash) January 9, 2026 20:42
@Zacqary Zacqary changed the title [Dashboard] Highlight focused panels in accent color [Dashboard] Highlight focused panels in non-animated gradient border Jan 9, 2026
@Zacqary Zacqary requested a review from andreadelrio January 9, 2026 21:23
@Zacqary Zacqary disabled auto-merge January 9, 2026 21:54
@andreadelrio
Copy link
Contributor

@Zacqary @ThomThomson I understand the problem you're trying to solve and it makes sense to solve to me. However, I think the gradient glow is visually too much to be visible for more than a fraction of a second (like when we insert a panel). Can we instead use the styling we use when dragging a panel?

CleanShot 2026-01-09 at 13 53 54@2x

@Zacqary
Copy link
Contributor Author

Zacqary commented Jan 9, 2026

@andreadelrio Is this better?

Screenshot 2026-01-09 at 4 21 10 PM

@andreadelrio
Copy link
Contributor

@Zacqary yes, for me that's much better

@Zacqary Zacqary enabled auto-merge (squash) January 26, 2026 17:28
@Zacqary Zacqary merged commit 6f203b7 into elastic:main Jan 26, 2026
16 checks passed
@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants