[Dashboard] Highlight focused panels in non-animated gradient border#248534
Merged
Zacqary merged 7 commits intoelastic:mainfrom Jan 26, 2026
Merged
[Dashboard] Highlight focused panels in non-animated gradient border#248534Zacqary merged 7 commits intoelastic:mainfrom
Zacqary merged 7 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Zacqary
commented
Jan 9, 2026
| borderRadius: euiTheme.border.radius.medium, | ||
| animation: `${borderSpinKeyframes} ${highlightAnimationDuration}ms ease-out`, | ||
| }, | ||
| '&.dshDashboardGrid__item--highlighted:not(&.dshDashboardGrid__item--focused) .embPanel::before': |
Contributor
Author
There was a problem hiding this comment.
Adding this :not selector disables the highlight animation when you create a panel and then immediately bring it into focus. Since the focusing border uses the same pseudo-element, and the highlight animation fades the opacity to 0, this created a jarring effect.
Contributor
|
@Zacqary @ThomThomson I understand the problem you're trying to solve and it makes sense to solve to me. However, I think the gradient glow is visually too much to be visible for more than a fraction of a second (like when we insert a panel). Can we instead use the styling we use when dragging a panel?
|
Contributor
Author
|
@andreadelrio Is this better?
|
Contributor
|
@Zacqary yes, for me that's much better |
ThomThomson
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds the gradient border from
highlightedpanels tofocusedpanels, without the animation