[9.1] [@kbn/scout] Add runtime validation for global.setup.ts (#248113)#248516
Merged
steliosmavro merged 2 commits intoelastic:9.1from Jan 13, 2026
Merged
[9.1] [@kbn/scout] Add runtime validation for global.setup.ts (#248113)#248516steliosmavro merged 2 commits intoelastic:9.1from
global.setup.ts (#248113)#248516steliosmavro merged 2 commits intoelastic:9.1from
Conversation
…8113) ## Summary This PR replaces the ESLint rule `scout_require_global_setup_hook_in_parallel_tests` with a runtime validation in Scout's config validator. The runtime check is more reliable since it validates the actual config and filesystem state at execution time, rather than relying on static analysis. ## Changes **Runtime validation in `@kbn/scout`:** - Added `runGlobalSetup` to `ScoutTestOptions` type - `createPlaywrightConfig` now passes `runGlobalSetup` to the config's `use` object - `validatePlaywrightConfig` checks that `global.setup.ts` exists when `runGlobalSetup: true` - Clear error message with expected file path and resolution steps **Removed ESLint rule:** - Deleted `scout_require_global_setup_hook_in_parallel_tests.js` rule and tests - Removed from `kbn-eslint-plugin-eslint/index.js` exports - Removed from `.eslintrc.js` configuration ## Why runtime over ESLint? - ESLint can't reliably check filesystem/config consistency when values are computed dynamically - Runtime validation catches the issue at the right moment (before tests run) - Having `global.setup.ts` present but unused is valid (teams may enable it later) - The opposite case (`runGlobalSetup: true` without the file) should fail fast (cherry picked from commit 80affb2) # Conflicts: # packages/kbn-eslint-plugin-eslint/rules/scout_require_global_setup_hook_in_parallel_tests.js # packages/kbn-eslint-plugin-eslint/rules/scout_require_global_setup_hook_in_parallel_tests.test.js # src/platform/packages/shared/kbn-scout/src/playwright/runner/config_validator.ts
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History |
csr
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:global.setup.ts(#248113)Questions ?
Please refer to the Backport tool documentation