Move helpers required for trace metrics to the apm-data-access plugin by viduni94 · Pull Request #248513 · elastic/kibana

viduni94 · 2026-01-09T17:46:00Z

Closes https://github.com/elastic/obs-ai-team/issues/452

Summary

This PR moves the trace metrics implementation from the APM plugin to the Observability Agent Builder plugin.

The reason for this change is to keep all the tool implementations within the Observability Agent Builder plugin.
(The trace metrics implementation was originally included in the APM plugin as it used some helpers defined in the APM plugin)

Changes

The trace metrics implementation was removed from the APM plugin and moved to the Observability Agent Builder plugin
Helpers used to calculate trace metrics that were located in the APM plugin were moved to the apm-data-access plugin (The Observability Agent Builder plugin already depends on the apm-data-access plugin)

Helpers that were moved from the APM plugin to the apm-data-access plugin:

calculateThroughputWithRange
getOutcomeAggregation
calculateFailedTransactionRate
getDurationFieldForTransactions
isSummaryFieldSupportedByDocType
getHasTransactionsEvents

Additionally, getRollupIntervalForTimeRange helper that was defined in the Observability Agent Builder plugin was also moved to the apm-data-access plugin. (See comment)

Checklist

The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

viduni94 · 2026-01-09T17:49:36Z

/ci

viduni94 · 2026-01-09T18:00:32Z

/ci

viduni94 · 2026-01-09T19:20:15Z

/ci

viduni94 · 2026-01-09T19:24:55Z

/ci

viduni94 · 2026-01-09T19:51:00Z

/ci

viduni94 · 2026-01-09T20:13:40Z

/ci

viduni94 · 2026-01-12T18:59:33Z

/ci

viduni94 · 2026-01-12T19:20:39Z

/ci

elasticmachine · 2026-01-12T19:37:43Z

Pinging @elastic/obs-ai-team (Team:obs-ai)

elasticmachine · 2026-01-12T20:02:50Z

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

elasticmachine · 2026-01-12T21:24:52Z

💔 Build Failed

Buildkite Build
Commit: 37260c3

Failed CI Steps

Check Types

History

💔 Build #380537 failed f2cf4fa
💔 Build #380523 failed f2cf4fa
💛 Build #379783 was flaky 1deab51
💔 Build #379778 failed efbe0c0
💔 Build #379769 failed 7ca9af3
💔 Build #379743 failed 5eeab7e

cc @viduni94

sorenlouv · 2026-01-13T09:57:41Z

.../observability/plugins/observability_agent_builder/server/tools/get_trace_metrics/handler.ts

+  const durationField = getDurationFieldForTransactions(documentType, hasDurationSummaryField);
+  const outcomeAggs = getOutcomeAggregation(documentType);
+
+  const response = await apmEventClient.search('get_trace_metrics', {


Woop! Awesome to see the apmEventClient working outside of the APM plugin!!

sorenlouv

Thank you Viduni!
I was worried how many new dependencies this would add to the apm-data-access plugin. It looks like zero? That's awesome!
With this change APM data is much more accessible.

sorenlouv · 2026-01-13T10:26:00Z

Are there other Agent Builder specifics queries in APM plugin that we can now move back to observability_agent_builder? Or was get_trace_metrics the only one?

Edit: yes, this one: #247810

rmyz

presentation changes LGTM

viduni94 · 2026-01-13T13:49:40Z

Thank you Viduni! I was worried how many new dependencies this would add to the apm-data-access plugin. It looks like zero? That's awesome! With this change APM data is much more accessible.

@sorenlouv
Yeah, no dependencies were added 🎉 Removed 1 dependency from the APM plugin as well (zod)

kibanamachine · 2026-01-13T13:51:16Z

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/20959174415

kibanamachine · 2026-01-13T13:58:50Z

💔 All backports failed

Status	Branch	Result
❌	9.3	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 248513

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2026-01-14T16:49:46Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 248513 locally
cc: @viduni94

…elastic#248513) Closes elastic/obs-ai-team#452 ## Summary This PR moves the trace metrics implementation from the APM plugin to the Observability Agent Builder plugin. - The reason for this change is to keep all the tool implementations within the Observability Agent Builder plugin. (The trace metrics implementation was originally included in the APM plugin as it used some helpers defined in the APM plugin) ### Changes - The trace metrics implementation was removed from the APM plugin and moved to the Observability Agent Builder plugin - Helpers used to calculate trace metrics that were located in the APM plugin were moved to the `apm-data-access` plugin (The Observability Agent Builder plugin already depends on the `apm-data-access` plugin) Helpers that were moved from the APM plugin to the `apm-data-access` plugin: - `calculateThroughputWithRange` - `getOutcomeAggregation` - `calculateFailedTransactionRate` - `getDurationFieldForTransactions` - `isSummaryFieldSupportedByDocType` - `getHasTransactionsEvents` Additionally, `getRollupIntervalForTimeRange` helper that was defined in the Observability Agent Builder plugin was also moved to the `apm-data-access` plugin. (See [comment](elastic#247474 (comment))) ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Move helpers required for traceMetrics to the apm-data-access plugin

6d99092

viduni94 self-assigned this Jan 9, 2026

viduni94 added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.3.0 Team:obs-ai Observability AI team v9.4.0 labels Jan 9, 2026

Move more helpers

9f15f8f

Fix import

5eeab7e

kibanamachine added 2 commits January 9, 2026 18:15

Changes from node scripts/lint_ts_projects --fix

b305c0b

Changes from node scripts/regenerate_moon_projects.js --update

365f94b

viduni94 added 2 commits January 9, 2026 14:23

Fix dependencies and import

e32ab22

Remove dep

7ca9af3

Fix dep

26ed802

Merge branch 'main' into move-helpers-to-apm-data-access-plugin

3e14fe0

viduni94 force-pushed the move-helpers-to-apm-data-access-plugin branch from 1deab51 to 3e14fe0 Compare January 12, 2026 18:10

viduni94 added 3 commits January 12, 2026 13:31

Update imports

45726ec

Remove duplicates

ce161ef

Fix

f2cf4fa

viduni94 changed the title ~~Move helpers required for traceMetrics to the apm-data-access plugin~~ Move helpers required for trace metrics to the apm-data-access plugin Jan 12, 2026

viduni94 marked this pull request as ready for review January 12, 2026 19:37

viduni94 requested a review from a team as a code owner January 12, 2026 19:37

kibanamachine added 2 commits January 12, 2026 19:51

Changes from node scripts/lint_ts_projects --fix

adb6675

Changes from node scripts/regenerate_moon_projects.js --update

7f2c4c4

botelastic bot added the Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation label Jan 12, 2026

Update export

37260c3

Fix export

c204f73

sorenlouv reviewed Jan 13, 2026

View reviewed changes

sorenlouv approved these changes Jan 13, 2026

View reviewed changes

sorenlouv mentioned this pull request Jan 13, 2026

[Obs Agent] add observability get_trace_change_points tool #247810

Merged

rmyz approved these changes Jan 13, 2026

View reviewed changes

viduni94 merged commit 9d99b7e into elastic:main Jan 13, 2026
13 checks passed

viduni94 removed the v9.3.0 label Jan 13, 2026

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 14, 2026

viduni94 added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Jan 14, 2026

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 14, 2026

Comments

Conversation

viduni94 commented Jan 9, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Checklist

Uh oh!

viduni94 commented Jan 9, 2026

Uh oh!

viduni94 commented Jan 9, 2026

Uh oh!

viduni94 commented Jan 9, 2026

Uh oh!

viduni94 commented Jan 9, 2026

Uh oh!

viduni94 commented Jan 9, 2026

Uh oh!

viduni94 commented Jan 9, 2026

Uh oh!

viduni94 commented Jan 12, 2026

Uh oh!

viduni94 commented Jan 12, 2026

Uh oh!

elasticmachine commented Jan 12, 2026

Uh oh!

elasticmachine commented Jan 12, 2026

Uh oh!

elasticmachine commented Jan 12, 2026

💔 Build Failed

Failed CI Steps

History

Uh oh!

sorenlouv Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmyz left a comment

Choose a reason for hiding this comment

Uh oh!

viduni94 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Jan 13, 2026

Uh oh!

kibanamachine commented Jan 13, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

viduni94 commented Jan 9, 2026 •

edited by kibanamachine

Loading

sorenlouv commented Jan 13, 2026 •

edited

Loading

viduni94 commented Jan 13, 2026 •

edited

Loading