Skip to content

🌊 [SigEvents] Run description generation as background task#248503

Merged
miltonhultgren merged 28 commits intoelastic:mainfrom
miltonhultgren:streams-sigevents-description-background-task
Jan 16, 2026
Merged

🌊 [SigEvents] Run description generation as background task#248503
miltonhultgren merged 28 commits intoelastic:mainfrom
miltonhultgren:streams-sigevents-description-background-task

Conversation

@miltonhultgren
Copy link
Contributor

@miltonhultgren miltonhultgren commented Jan 9, 2026

Similar to #245728, this makes the Stream description generation process a background task.

@github-actions github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Jan 9, 2026
@miltonhultgren miltonhultgren changed the title Streams sigevents description background task 🌊 [SigEvents] Run description generation as background task Jan 12, 2026
@miltonhultgren miltonhultgren added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.4.0 Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) labels Jan 12, 2026
@miltonhultgren miltonhultgren force-pushed the streams-sigevents-description-background-task branch from 7128bfb to 9dbfbd8 Compare January 12, 2026 09:40
@miltonhultgren miltonhultgren marked this pull request as ready for review January 13, 2026 09:30
@miltonhultgren miltonhultgren requested review from a team as code owners January 13, 2026 09:30
@miltonhultgren miltonhultgren requested a review from a team as a code owner January 13, 2026 11:27
Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM

Copy link
Contributor

@cesco-f cesco-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the task is running we should disable all the other buttons:

Screen.Recording.2026-01-14.at.17.21.07.mov
Screen.Recording.2026-01-14.at.17.08.04.mov

@miltonhultgren
Copy link
Contributor Author

@cesco-f Fixed in fcfd0b2

Copy link
Contributor

@cesco-f cesco-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd revert that change, but in general LGTM.

Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miltonhultgren miltonhultgren enabled auto-merge (squash) January 15, 2026 16:55
@miltonhultgren miltonhultgren merged commit 2a1858d into elastic:main Jan 16, 2026
13 checks passed
@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Jan 16, 2026
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 1444 1445 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 1.5MB 1.5MB +2.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
streams 25 26 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
streamsApp 23.1KB 22.5KB -560.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:actionable-obs PRs authored by the actionable obs team backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants