-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Contextual Security] Replace ENRICH with LOOKUP JOIN queries when fetching entities #247815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexreal1314
merged 36 commits into
elastic:main
from
alexreal1314:232226-lookup-entity-enrichment
Jan 21, 2026
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
30a210e
add entities enrichment using LOOKUP JOIN support with fallback to EN…
alexreal1314 5772f3e
stabalize graph api and ftr tests
alexreal1314 07a88b0
remove unsued consts from test files
alexreal1314 e51ce82
refactor graph api and ftr tests entity store init process
alexreal1314 6a42c44
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 60adfab
fix types
alexreal1314 3833d5e
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 a13e49a
fix graph entity store test cases flakines
alexreal1314 f35926e
add waitForEntityStoreReady to wait before executing enrich policy
alexreal1314 8d330e0
investigate flaky tests
alexreal1314 f17534a
investigate flaky tests
alexreal1314 5ce1210
add init of default data view in graph ftr tests
alexreal1314 9909ec9
fix flaky tests
alexreal1314 fbfbc5c
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 66be86a
refactor entity store init
alexreal1314 acd53af
add init entity store with retry
alexreal1314 ded7ba8
alight graph api integration test entity store init with ftr tests
alexreal1314 3edc11c
uncomment all ftr tests
alexreal1314 685748f
fix fetch graph unit test
alexreal1314 d1af562
convert graph ftr tests to run sequentially and load entity store onl…
alexreal1314 ec33938
make graph api integrations tests to run entity store tests sequentia…
alexreal1314 f541fc8
fix missing import
alexreal1314 62f75fa
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 3028fa3
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 6f6e21b
update esql query to handle null value in entity store documents
alexreal1314 3e12aae
move graph api entity store tests to a custom space
alexreal1314 d3d72cb
fix entity flyout graph ftr tests and test both enrich and lookup flows
alexreal1314 23093da
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 03fed8e
extract LOOKUP JOIN and ENRICH ESQL builders into utility functions
alexreal1314 77c7d0a
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 b7e0285
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 a443c38
rename entity_flyout ftr test to entity_preview_flyout
alexreal1314 8c07a8c
handle partial entity data in ESQL JSON construction
alexreal1314 b86620b
remove empty line
alexreal1314 44310e6
Merge branch 'main' into 232226-lookup-entity-enrichment
alexreal1314 83a2e71
simplify ESQL entity JSON construction and add Storage icon mapping
alexreal1314 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for confirmation whether we are moving to a new v2 index or migrating existing v1.
cc @romulets @uri-weisman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna keep it under v2 - atm migration of v1 to lookup mode is not planned