Simple query #24745
Merged
Simple query #24745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
Contributor
Author
|
I need to add Test but we can still see how it works for now |
x-pack/plugins/secops/public/containers/who_am_i/who_am_i.gql_query.ts
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
|
Build failure is case sensitivity issues: |
Contributor
|
Pre-approved this as long as builds work and are green I am fine with this being merged. |
FrankHassanabad
approved these changes
Oct 29, 2018
Contributor
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
As long as builds and conflicts are resolved this looks good. If Unit tests are added, I will re-review those with this again.
add translations for region_map plugin
add translations for table vis plugin
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
FrankHassanabad
approved these changes
Oct 30, 2018
Contributor
💚 Build Succeeded |
andrew-goldstein
pushed a commit
that referenced
this pull request
Dec 4, 2018
* Translations for Region Map (#23875) add translations for region_map plugin * Translations for Table Vis plugin (#23679) add translations for table vis plugin * add a simple example/flow to see what need to be done to query with graphql * work review * simple test for source schema * fix some reviewing and add resolver test code for source * review by Andrew G
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we just wanted to create a simple example to show the interaction between container and pages folder.
And also to create a small query with grapql like that: