Feature/translate monitoring elasticsearch part 2#24734
Merged
maryia-lapata merged 32 commits intoelastic:masterfrom Nov 16, 2018
Merged
Feature/translate monitoring elasticsearch part 2#24734maryia-lapata merged 32 commits intoelastic:masterfrom
maryia-lapata merged 32 commits intoelastic:masterfrom
Conversation
second merge
Contributor
💚 Build Succeeded |
maryia-lapata
suggested changes
Oct 30, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
Good job! Please fix some comments.
x-pack/plugins/monitoring/public/directives/elasticsearch/shard_allocation/index.html
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/public/directives/elasticsearch/shard_allocation/index.html
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/public/views/elasticsearch/index/advanced/index.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/public/views/elasticsearch/index/index.js
Outdated
Show resolved
Hide resolved
Contributor
|
Title, status and placeholder should be translated as well here: |
Contributor
💚 Build Succeeded |
…-part_2 # Conflicts: # .i18nrc.json
x-pack/plugins/monitoring/public/directives/elasticsearch/ml_job_listing/index.js
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
…-part_2 # Conflicts: # .i18nrc.json
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 21, 2018
* Translate monitoring -> view -> elasticsearch * Fix issues * Translate monitoring - view - elasticsearch and kibana * Fix issues * Fix issues * Fix issues * Fix placeholder value
maryia-lapata
added a commit
that referenced
this pull request
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate monitoring -> public -> directives and views -> kibana and elasticsearch
Fixes: #24713