-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Added Enhancements to Log Ai Insight #247291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuliia-fryshko
merged 85 commits into
elastic:main
from
yuliia-fryshko:edit-log-insight-system-promt-445
Feb 3, 2026
+590
−119
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
c9aab67
Added Remediation Steps to Log Ai Insight system promt
yuliia-fryshko 44b44e2
edited system promt
yuliia-fryshko b64015b
added downstream dependencies
yuliia-fryshko a87c1dc
added trace data
yuliia-fryshko e5d48e5
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko e02947c
edit log ai system promt to respond base on log type
yuliia-fryshko 769fee0
edited wording
yuliia-fryshko e50dd81
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 52ee4df
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko ac070e8
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko b8c86ee
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine b0685ce
applied PR review suggestions
yuliia-fryshko 55affb9
removed first occurence promt
yuliia-fryshko 0b45ec5
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 3124e3a
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko e1309f1
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 2112716
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko a57c8be
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 384bced
prefetched data base on log severity
yuliia-fryshko 2523a21
removed redundant fallback
yuliia-fryshko 35b7291
added a condition to identify id the log is an error
yuliia-fryshko 0e6ac58
rename getToolHandler import to getCorrelatedLogs
yuliia-fryshko 2ad03d3
adjusted fields according to mapping ecs-otel
yuliia-fryshko ab652c6
adjusted correlated log sequence
yuliia-fryshko 94135cc
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 35ec4bd
added API test for Log AI Insight
yuliia-fryshko d9b647f
addressed review comment
yuliia-fryshko 07ce96a
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko f4382fe
fix type check
yuliia-fryshko c5d3a6f
fixed check type
yuliia-fryshko ae8568f
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 6fd1ce8
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 33b4b6b
prefetch correlation logs for all log types
yuliia-fryshko 6130807
fix merge conflict
yuliia-fryshko f009254
fix merge conflict
yuliia-fryshko 5ce23e8
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 2423a38
search ecs fields instead of source
yuliia-fryshko e56b156
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko d70c2fd
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko c907227
fixed merge conflicts
yuliia-fryshko 5dc626c
added categorised logs and default values for correlation tool handler
yuliia-fryshko 73ccf32
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko bd60b60
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko cf98e3a
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko 5c124c5
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine e9fd179
fix review comments
yuliia-fryshko 8a6da49
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 7bbe53d
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko b220f84
fixed tests
yuliia-fryshko 7719f35
moved the function to utils
yuliia-fryshko 15fa737
Update x-pack/solutions/observability/test/api_integration_deployment…
yuliia-fryshko c389435
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko efb1d96
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko 1dea11f
Update x-pack/solutions/observability/test/api_integration_deployment…
yuliia-fryshko 1973cbd
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 775b93c
fixed review comments
yuliia-fryshko ab0c124
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 01b7d1b
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko ca63002
fixed merge conflict
yuliia-fryshko 53f8492
fix duplicates, add shared test helpers
yuliia-fryshko e95c9c2
Changes from node scripts/lint_ts_projects --fix
kibanamachine 0b5b0cd
Changes from node scripts/regenerate_moon_projects.js --update
kibanamachine 58c53df
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko e6bee31
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 841558f
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 8d98f5c
removed categorised logs; fixed check type
yuliia-fryshko 3b2bda0
added ditributed trace data when error
yuliia-fryshko 95c5a02
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine a4af6d0
removed duplications of tests
yuliia-fryshko f752200
removed distributed trace
yuliia-fryshko 5d835e2
fix tests
yuliia-fryshko 306143a
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko 90e3885
created a function to call corelated logs
yuliia-fryshko 6c67d8d
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko b47a1e6
fixed review comments
yuliia-fryshko 4ea551b
fixed check type
yuliia-fryshko 8f6049e
fixed check type
yuliia-fryshko 51a1ba8
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine f2faa93
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko cac6cfc
Merge branch 'main' into edit-log-insight-system-promt-445
yuliia-fryshko 430b890
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko a3a965b
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko 6500993
Update x-pack/solutions/observability/plugins/observability_agent_bui…
yuliia-fryshko 999af77
fixed review comment
yuliia-fryshko bbce724
fixed type check
yuliia-fryshko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording here is a bit ambiguous I feel.
If it's an issuedoesn't clearly say what an issue is?Is it referring to an error log or a warning log? What can be considered as an issue in this context?
And do we need to say
suitable for an on-call SRE?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's an issue- I added it because, in the message, we ask to explain the log and whether "it is an issue". We didn’t specify what qualifies as an issue there. I’m happy to clarify it if you think it’s needed, but the LLM was able to define it nicely on its own.Regarding
suitable for an on-call SRE- I added this because we already mention in the system promt that the audience is an SRE, and I assume that if there is an issue, we want to provide some next steps to investigate. I don’t have a strong opinion on keeping this part or not and am happy to change it.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should change as well. We have to avoid ambiguity in system prompt and instructions as much as possible, as different LLMs may interpret it in different ways if it's ambiguous.