Skip to content

[Streams] Improve condition filtering#247095

Closed
LucaWintergerst wants to merge 2 commits intoelastic:mainfrom
LucaWintergerst:improved-condition-filtering
Closed

[Streams] Improve condition filtering#247095
LucaWintergerst wants to merge 2 commits intoelastic:mainfrom
LucaWintergerst:improved-condition-filtering

Conversation

@LucaWintergerst
Copy link
Copy Markdown
Contributor

Improves condition filtering with accurate match rate tracking

CleanShot.2025-12-19.at.14.55.30.mp4

What Changed

Server-side:

  • Adds simulation-only no-op processors (set+remove) for each condition block to track match rates
  • Enables accurate condition metrics even when conditions have no children or faulty descendants
  • Filters out condition no-op processors from document status/diff calculations

Client-side:

  • Auto-selects parent condition when creating/editing processors under it for better UX
  • Derives document metrics from filtered simulation results based on selected condition
  • Displays condition match rate badges on WHERE blocks
  • Removes processor-level skipped rate display (now shown only at condition level)
  • Simplifies condition filtering logic to use noop processor tags directly

Code cleanup:

  • Removes dead steps parameter from collectActiveDocumentsForSelectedCondition
  • Removes logic that required traversing step tree for condition filtering

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@LucaWintergerst LucaWintergerst requested review from a team as code owners December 19, 2025 13:58
@LucaWintergerst LucaWintergerst marked this pull request as draft December 19, 2025 13:59
@elasticmachine
Copy link
Copy Markdown
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 19, 2025

💔 Build Failed

Failed CI Steps

History

@flash1293
Copy link
Copy Markdown
Contributor

Taken over by #251129

@flash1293 flash1293 closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants