Skip to content

[Index Management] Fix error on index lifecycle summary tab #246606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damian-polewski merged 2 commits into from
Dec 18, 2025
Merged

[Index Management] Fix error on index lifecycle summary tab #246606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aee81ef
fix: error on index lifecycle summary tab
damian-polewski Dec 16, 2025
a3c9267
Merge branch 'main' into index_management/fix_hook_error_on_index_lif…
damian-polewski Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...tform/packages/shared/index-management/index_management_shared_types/src/home_sections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,20 @@ export interface IndexDetailsTab {
id: IndexDetailsTabId;
// a text that is displayed on the tab label, usually a Formatted message component
name: ReactNode;
// a function that renders the content of the tab
/**
* A function that renders the content of the tab.
*
* IMPORTANT: This expects an arrow function that returns JSX, NOT a component passed directly.
*
* @example
* // Correct - arrow function returning JSX:
* renderTabContent: ({ index, getUrlForApp }) => (
* <MyTabComponent index={index} getUrlForApp={getUrlForApp} />
* )
*
* // Wrong - passing a component directly will break if it uses hooks:
* renderTabContent: MyTabComponent
*/
renderTabContent: (args: {
index: Index;
getUrlForApp: ApplicationStart['getUrlForApp'];
Expand Down
13 changes: 7 additions & 6 deletions ...ifecycle_management/public/extend_index_management/components/index_lifecycle_summary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
* 2.0.
*/

import type { FunctionComponent } from 'react';
import React from 'react';
import moment from 'moment-timezone';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { css } from '@emotion/react';
import type { EuiBadgeProps, EuiThemeComputed } from '@elastic/eui';
import type { EuiBadgeProps } from '@elastic/eui';
import {
EuiCodeBlock,
EuiLink,
Expand All @@ -31,13 +30,13 @@ import type { IlmExplainLifecycleLifecycleExplainManaged } from '@elastic/elasti
import type { Phase } from '../../../common/types';
import { getPolicyEditPath } from '../../application/services/navigation';
import { usePhaseColors } from '../../application/lib';
interface Props {

interface IndexLifecycleSummaryProps {
index: Index;
getUrlForApp: ApplicationStart['getUrlForApp'];
euiTheme: EuiThemeComputed;
}

export const IndexLifecycleSummary: FunctionComponent<Props> = ({ index, getUrlForApp }) => {
export const IndexLifecycleSummary = ({ index, getUrlForApp }: IndexLifecycleSummaryProps) => {
const { ilm: ilmData } = index;
// only ILM managed indices render the ILM tab
const ilm = ilmData as IlmExplainLifecycleLifecycleExplainManaged;
Expand Down Expand Up @@ -256,7 +255,9 @@ export const indexLifecycleTab: IndexDetailsTab = {
/>
),
order: 50,
renderTabContent: IndexLifecycleSummary,
renderTabContent: ({ index, getUrlForApp }) => (
<IndexLifecycleSummary index={index} getUrlForApp={getUrlForApp} />
),
shouldRenderTab: ({ index }) => {
return !!index.ilm && index.ilm.managed;
},
Expand Down