[AI Infra] Chat experience documentation links#246334
Conversation
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/appex-ai-infra (Team:AI Infra) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
florent-leborgne
left a comment
There was a problem hiding this comment.
Link and copy lgtm overall - Left a few suggestions for you to consider on the strings actually changed by this PR
| id="aiAssistantManagementSelection.headerButton.description" | ||
| defaultMessage={ | ||
| 'Choose which chat experience to use throughout Kibana. {learnMoreLink}. <bold>This setting applies to all users in the space.</bold> To change it later, go to {genAiSettings}.' | ||
| 'Choose which chat experience to use throughout Kibana. {learnMoreLink}. <bold>This setting applies to all users in the space.</bold> To change it later, go to {genAiSettings}' |
There was a problem hiding this comment.
| 'Choose which chat experience to use throughout Kibana. {learnMoreLink}. <bold>This setting applies to all users in the space.</bold> To change it later, go to {genAiSettings}' | |
| 'Choose which chat experience to use throughout Kibana. {learnMoreLink}. <bold>This setting applies to all users in the space.</bold> To change it later, go to {genAiSettings}.' |
It's still a sentence we should keep the punctuation
There was a problem hiding this comment.
Thanks! This is fixed here ed38b53c01d0299f932aa8aa6ff7977e2e1fe5b4
| By default, Elastic uses its Elastic Managed LLM connector ({additionalCostsIncur}) when no custom connectors are available. | ||
| When available, Elastic uses the last used custom connector. Set up your own connectors or disable the AI Assistant from the AI feature visibility setting below. | ||
| Select a default AI connector to enforce the choice for your space. {manageConnectors}`} | ||
| defaultMessage={`AI-powered features require a large language model (LLM) connector. You can configure a third-party connector or use the Elastic Managed LLM ({atAdditionalCost}). |
There was a problem hiding this comment.
| defaultMessage={`AI-powered features require a large language model (LLM) connector. You can configure a third-party connector or use the Elastic Managed LLM ({atAdditionalCost}). | |
| defaultMessage={`AI-powered features require a large language model (LLM) connector. You can use the Elastic Managed LLM ({atAdditionalCost}) or configure a third-party connector. |
we should mention ours first I think - Isn't "Elastic Managed LLM" getting a new name by the way?
| When available, Elastic uses the last used custom connector. Set up your own connectors or disable the AI Assistant from the AI feature visibility setting below. | ||
| Select a default AI connector to enforce the choice for your space. {manageConnectors}`} | ||
| defaultMessage={`AI-powered features require a large language model (LLM) connector. You can configure a third-party connector or use the Elastic Managed LLM ({atAdditionalCost}). | ||
| When using these features, this space's Default AI connector is pre-selected. To prevent the use of other connectors, enable Disallow all other connectors. |
There was a problem hiding this comment.
| When using these features, this space's Default AI connector is pre-selected. To prevent the use of other connectors, enable Disallow all other connectors. | |
| When you set a default AI connector, it is pre-selected for all of these features in this space. |
2 considerations here:
- A suggestion to make the 1st part of this paragraph sound a bit better
- Is the second sentence really necessary? The "Disallow..." option is visible in the UI with a clear title and it looks like it has a tooltip
| Select a default AI connector to enforce the choice for your space. {manageConnectors}`} | ||
| defaultMessage={`AI-powered features require a large language model (LLM) connector. You can configure a third-party connector or use the Elastic Managed LLM ({atAdditionalCost}). | ||
| When using these features, this space's Default AI connector is pre-selected. To prevent the use of other connectors, enable Disallow all other connectors. | ||
| If no default is set, the last-used connector will be selected automatically. {manageConnectors}`} |
There was a problem hiding this comment.
| If no default is set, the last-used connector will be selected automatically. {manageConnectors}`} | |
| If you haven't set a default, the most recently used connector is selected automatically. {manageConnectors}`} |
Sounds slightly better IMO and is consistent with the rest of the suggestions above
| // TODO: add the actual link when available | ||
| link: '<a href="" target="_blank" rel="noopener noreferrer" class="euiLink euiLink--primary">Learn more</a>', | ||
| }, | ||
| defaultMessage: 'Choose which chat experience to use for everyone in this space.', |
There was a problem hiding this comment.
| defaultMessage: 'Choose which chat experience to use for everyone in this space.', | |
| defaultMessage: 'Choose which chat experience to use for all users in this space.', |
to be consistent with other similar sentences I've seen
walterra
left a comment
There was a problem hiding this comment.
vis team code review: LGTM, just removal of an eslint ignore.
|
Pinging @elastic/obs-ai-team (Team:obs-ai) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
cc @KodeRad |
…46657) ## Summary As a follow-up to #246099 and #246334, this PR adds `docLinks` off to the [AI Assistant Settings Docs](https://www.elastic.co/docs/reference/kibana/configuration-reference/ai-assistant-settings) to both the `Documentation` panel and error toasts when the artifact fails to install (in aid of those in air-gapped environments). Note: Yes, air-gapped deployments won't be able to load the documentation link, but they'll at least have the URL they need to get further information. <p align="center"> <img width="700" src="https://github.com/user-attachments/assets/c15afd58-31b4-4f03-a489-ad21a983b6cf" /> </p> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
Implements: https://github.com/elastic/ml-team/issues/1755
Follow up to: #244532
The goal of this PR is to:
GenAI Settingspage(Beta)toAI Agentdrop-down Chat Experience optionTo test it you have to activate feature flag in
kibana.dev.ymlScreenshots
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.