[AI Infra] View Chat Experience setting and documentation section requires all privileges#246311
Merged
KodeRad merged 5 commits intoelastic:mainfrom Dec 16, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
|
Pinging @elastic/appex-ai-infra (Team:AI Infra) |
| config.showAiAssistantsVisibilitySetting === false ? false : !isSolutionView; | ||
|
|
||
| const hasObservabilityAssistant = | ||
| services.application.capabilities.observabilityAIAssistant?.show === true; |
Member
There was a problem hiding this comment.
nit, capabilities could be extracted on line 40. just to make this code a bit more readable.
const {
services: {
spaces,
application: { capabilities },
},
} = useKibana();
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jgowdyelastic
approved these changes
Dec 15, 2025
Member
jgowdyelastic
left a comment
There was a problem hiding this comment.
Code LGTM
I added one code clean up comment
spong
reviewed
Dec 15, 2025
| </EuiSplitPanel.Inner> | ||
| </EuiSplitPanel.Outer> | ||
|
|
||
| {isAgentExperience && ( |
Member
There was a problem hiding this comment.
Thanks for this fix @KodeRad! This fixes the corner case where the user enables the FF, then the Agent experience, then removes the feature flag, at which point the app would return to the default chat experience but this UI would still show.
rbrtj
approved these changes
Dec 15, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @KodeRad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements: https://github.com/elastic/ml-team/issues/1755
Follow up to: #244532
The goal of this PR is to make Chat Experience visible only for users who have all privileges. This is
Agentand at least one Classic Assistant.DocumentationSectionis now displayed only if Chat Experience is present and Agent is chosenTo test it you have to activate feature flag in
kibana.dev.ymlChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.