Skip to content

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 12, 2025

Caution

⚠️ Changes / translations were made by GenAI. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right.

Summary

This PR applies the auto-fix for the newly introduced @elastic/eui/require-table-caption.
This rule ensure EuiInMemoryTable, EuiBasicTable have a tableCaption prop for accessibility.

Changes

  1. 🎯 Added missing tableCaption attributes to elements flagged by @elastic/eui/require-table-caption — accessibility leveled up!

Related

This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team!

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.3.0 v9.2.3 v9.1.9 Project:Accessibility labels Dec 12, 2025
@alexwizp alexwizp marked this pull request as ready for review December 12, 2025 19:48
@alexwizp alexwizp requested a review from a team as a code owner December 12, 2025 19:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elastic elastic deleted a comment from elasticmachine Dec 12, 2025
@alexwizp
Copy link
Contributor Author

@elastic/stack-monitoring please review

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 631.6KB 632.7KB +1.1KB

Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@alexwizp alexwizp merged commit 2a356a9 into elastic:main Dec 16, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/20269800619

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 16, 2025
…@elastic/stack-monitoring` files (elastic#246139)

> [!CAUTION]
> ⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them
carefully, but your code owners’ expert eyes will ensure they’re 100%
right.

## Summary
This PR applies the auto-fix for the newly introduced
`@elastic/eui/require-table-caption`.
This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a
`tableCaption` prop for accessibility.

## Changes

1. 🎯 Added missing `tableCaption` attributes to elements flagged by
`@elastic/eui/require-table-caption` — accessibility leveled up!

## Related
- elastic/eui#9168

This time, to avoid annoying approvals collection, we've broken files
down by teams. Now, we are waiting a review only from your team!

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2a356a9)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 16, 2025
…@elastic/stack-monitoring` files (elastic#246139)

> [!CAUTION]
> ⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them
carefully, but your code owners’ expert eyes will ensure they’re 100%
right.

## Summary
This PR applies the auto-fix for the newly introduced
`@elastic/eui/require-table-caption`.
This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a
`tableCaption` prop for accessibility.

## Changes

1. 🎯 Added missing `tableCaption` attributes to elements flagged by
`@elastic/eui/require-table-caption` — accessibility leveled up!

## Related
- elastic/eui#9168

This time, to avoid annoying approvals collection, we've broken files
down by teams. Now, we are waiting a review only from your team!

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 2a356a9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1
9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 16, 2025
…ross `@elastic/stack-monitoring` files (#246139) (#246549)

# Backport

This will backport the following commits from `main` to `9.2`:
- [Address `@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files
(#246139)](#246139)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-12-16T13:35:47Z","message":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files (#246139)\n\n> [!CAUTION]\n> ⚠️
**Changes / translations were made by GenAI**. I’ve reviewed
them\ncarefully, but your code owners’ expert eyes will ensure they’re
100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly
introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure
`EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for
accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption`
attributes to elements flagged by\n`@elastic/eui/require-table-caption`
— accessibility leveled up!\n\n## Related\n-
https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying
approvals collection, we've broken files\ndown by teams. Now, we are
waiting a review only from your team!\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2a356a981c06b7c30627ed457986364ff2bb7b3d","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.3.0","v9.2.3","v9.1.9"],"title":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring`
files","number":246139,"url":"https://github.com/elastic/kibana/pull/246139","mergeCommit":{"message":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files (#246139)\n\n> [!CAUTION]\n> ⚠️
**Changes / translations were made by GenAI**. I’ve reviewed
them\ncarefully, but your code owners’ expert eyes will ensure they’re
100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly
introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure
`EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for
accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption`
attributes to elements flagged by\n`@elastic/eui/require-table-caption`
— accessibility leveled up!\n\n## Related\n-
https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying
approvals collection, we've broken files\ndown by teams. Now, we are
waiting a review only from your team!\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2a356a981c06b7c30627ed457986364ff2bb7b3d"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246139","number":246139,"mergeCommit":{"message":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files (#246139)\n\n> [!CAUTION]\n> ⚠️
**Changes / translations were made by GenAI**. I’ve reviewed
them\ncarefully, but your code owners’ expert eyes will ensure they’re
100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly
introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure
`EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for
accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption`
attributes to elements flagged by\n`@elastic/eui/require-table-caption`
— accessibility leveled up!\n\n## Related\n-
https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying
approvals collection, we've broken files\ndown by teams. Now, we are
waiting a review only from your team!\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2a356a981c06b7c30627ed457986364ff2bb7b3d"}},{"branch":"9.2","label":"v9.2.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine added a commit that referenced this pull request Dec 17, 2025
…ross `@elastic/stack-monitoring` files (#246139) (#246548)

# Backport

This will backport the following commits from `main` to `9.1`:
- [Address `@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files
(#246139)](#246139)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-12-16T13:35:47Z","message":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files (#246139)\n\n> [!CAUTION]\n> ⚠️
**Changes / translations were made by GenAI**. I’ve reviewed
them\ncarefully, but your code owners’ expert eyes will ensure they’re
100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly
introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure
`EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for
accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption`
attributes to elements flagged by\n`@elastic/eui/require-table-caption`
— accessibility leveled up!\n\n## Related\n-
https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying
approvals collection, we've broken files\ndown by teams. Now, we are
waiting a review only from your team!\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2a356a981c06b7c30627ed457986364ff2bb7b3d","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.3.0","v9.2.3","v9.1.9"],"title":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring`
files","number":246139,"url":"https://github.com/elastic/kibana/pull/246139","mergeCommit":{"message":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files (#246139)\n\n> [!CAUTION]\n> ⚠️
**Changes / translations were made by GenAI**. I’ve reviewed
them\ncarefully, but your code owners’ expert eyes will ensure they’re
100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly
introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure
`EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for
accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption`
attributes to elements flagged by\n`@elastic/eui/require-table-caption`
— accessibility leveled up!\n\n## Related\n-
https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying
approvals collection, we've broken files\ndown by teams. Now, we are
waiting a review only from your team!\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2a356a981c06b7c30627ed457986364ff2bb7b3d"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246139","number":246139,"mergeCommit":{"message":"Address
`@elastic/eui/require-table-caption` lint violations across
`@elastic/stack-monitoring` files (#246139)\n\n> [!CAUTION]\n> ⚠️
**Changes / translations were made by GenAI**. I’ve reviewed
them\ncarefully, but your code owners’ expert eyes will ensure they’re
100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly
introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure
`EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for
accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption`
attributes to elements flagged by\n`@elastic/eui/require-table-caption`
— accessibility leveled up!\n\n## Related\n-
https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying
approvals collection, we've broken files\ndown by teams. Now, we are
waiting a review only from your team!\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2a356a981c06b7c30627ed457986364ff2bb7b3d"}},{"branch":"9.2","label":"v9.2.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
@mistic mistic removed the v9.1.9 label Dec 19, 2025
@mistic mistic added the v9.1.10 label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.1.10 v9.2.3 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants