-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Workspace Chrome] Visual Improvements #245898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace Chrome] Visual Improvements #245898
Conversation
…nable this "app sheet" look
This reverts commit 5b7efdc.
…c#244628) One user-facing change we made with [the grid layout](elastic#243181) is that we started displaying the Kibana header next to the sidenav instead of above it. **Before grid layout** <img width="630" height="409" alt="Screenshot 2025-10-31 at 11 22 32" src="https://github.com/user-attachments/assets/f04eaf6a-9605-4346-b105-e172b5f990f2" /> **With grid layout** <img width="591" height="290" alt="Screenshot 2025-10-31 at 11 25 24" src="https://github.com/user-attachments/assets/6e34f379-d979-4c82-a6fc-1c94811f17b6" /> ----- With this PR, we revert this user-facing change and return the header to the top of the nav. <img width="1624" height="1056" alt="Screenshot 2025-11-28 at 12 54 38" src="https://github.com/user-attachments/assets/b8bb6a56-4983-4341-9ae6-e52ac46b5636" />
The layout wrapper has a floating border on a pseudo element, but the children have different z-index levels (e.g. the top bar) which then overlap the container border. Since we want the border to be visible at all times, a regular border would be more fitting here. Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
- EUI updated the type and the query might be null for text searches
…o "combobox" in DataView list component
justinkambic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obs UI change looks good to me!
mohamedhamed-ahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
|
## Summary Update the look and feel of the Solution chrome. Epic: elastic/kibana-team#2106 Includes elastic#245099 **Changes:** | Area | Change |-|- | Navigation collapse button | <li>moved from the chrome header to the navigation footer | Application space, App menu bar | <li>globally consistent white background (due to changes in EUI v110)<br><li>drop shadow | Application space| <li>Spacing at the bottom and right sides between the app content<br>Spacing when the navigation side panel shows (conditionally) | Global header background | <li>shaded ### Things to test 1. dark mode 2. the expanded/collapsed nav 3. secondary nav panel 4. embedded console button at the bottom of the screen (Elasticsearch space) 5. high contrast mode ## Screenshots **Before** 1. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/75a1ded1-f102-42ec-bc7e-804c27b4455b" /> 6. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/5301dd03-4cdb-4cd3-8fba-517adfd26b29" /> 7. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/b69c176b-7a8a-4d1f-879f-970010381483" /> **After** 1. <img width="1836" height="1100" alt="image" src="https://github.com/user-attachments/assets/7d2b9d75-ee83-4893-83f4-9a6561fd1e04" /> 2. <img width="1835" height="1100" alt="image" src="https://github.com/user-attachments/assets/ae70825b-a52c-43b5-867f-3efd02681c60" /> 3. <img width="1835" height="1100" alt="image" src="https://github.com/user-attachments/assets/177d896c-8e9b-4810-839c-934ea9c7a3a8" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Audit all Kibana pages for consistency of stylistic changes - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ ### Identify risks ~~Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.~~ ~~Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.~~ - ~~[ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)~~ - ~~[ ] ...~~ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co> Co-authored-by: Jorge Oliveira <jorge.oliveira@elastic.co> Co-authored-by: ek-so <eksomail@gmail.com> Co-authored-by: Kate Sosedova <36230123+ek-so@users.noreply.github.com>
## Summary Update the look and feel of the Solution chrome. Epic: elastic/kibana-team#2106 Includes elastic#245099 **Changes:** | Area | Change |-|- | Navigation collapse button | <li>moved from the chrome header to the navigation footer | Application space, App menu bar | <li>globally consistent white background (due to changes in EUI v110)<br><li>drop shadow | Application space| <li>Spacing at the bottom and right sides between the app content<br>Spacing when the navigation side panel shows (conditionally) | Global header background | <li>shaded ### Things to test 1. dark mode 2. the expanded/collapsed nav 3. secondary nav panel 4. embedded console button at the bottom of the screen (Elasticsearch space) 5. high contrast mode ## Screenshots **Before** 1. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/75a1ded1-f102-42ec-bc7e-804c27b4455b" /> 6. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/5301dd03-4cdb-4cd3-8fba-517adfd26b29" /> 7. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/b69c176b-7a8a-4d1f-879f-970010381483" /> **After** 1. <img width="1836" height="1100" alt="image" src="https://github.com/user-attachments/assets/7d2b9d75-ee83-4893-83f4-9a6561fd1e04" /> 2. <img width="1835" height="1100" alt="image" src="https://github.com/user-attachments/assets/ae70825b-a52c-43b5-867f-3efd02681c60" /> 3. <img width="1835" height="1100" alt="image" src="https://github.com/user-attachments/assets/177d896c-8e9b-4810-839c-934ea9c7a3a8" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Audit all Kibana pages for consistency of stylistic changes - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ ### Identify risks ~~Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.~~ ~~Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.~~ - ~~[ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)~~ - ~~[ ] ...~~ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co> Co-authored-by: Jorge Oliveira <jorge.oliveira@elastic.co> Co-authored-by: ek-so <eksomail@gmail.com> Co-authored-by: Kate Sosedova <36230123+ek-so@users.noreply.github.com>
## Summary Update the look and feel of the Solution chrome. Epic: elastic/kibana-team#2106 Includes elastic#245099 **Changes:** | Area | Change |-|- | Navigation collapse button | <li>moved from the chrome header to the navigation footer | Application space, App menu bar | <li>globally consistent white background (due to changes in EUI v110)<br><li>drop shadow | Application space| <li>Spacing at the bottom and right sides between the app content<br>Spacing when the navigation side panel shows (conditionally) | Global header background | <li>shaded ### Things to test 1. dark mode 2. the expanded/collapsed nav 3. secondary nav panel 4. embedded console button at the bottom of the screen (Elasticsearch space) 5. high contrast mode ## Screenshots **Before** 1. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/75a1ded1-f102-42ec-bc7e-804c27b4455b" /> 6. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/5301dd03-4cdb-4cd3-8fba-517adfd26b29" /> 7. <img width="1835" height="1101" alt="image" src="https://github.com/user-attachments/assets/b69c176b-7a8a-4d1f-879f-970010381483" /> **After** 1. <img width="1836" height="1100" alt="image" src="https://github.com/user-attachments/assets/7d2b9d75-ee83-4893-83f4-9a6561fd1e04" /> 2. <img width="1835" height="1100" alt="image" src="https://github.com/user-attachments/assets/ae70825b-a52c-43b5-867f-3efd02681c60" /> 3. <img width="1835" height="1100" alt="image" src="https://github.com/user-attachments/assets/177d896c-8e9b-4810-839c-934ea9c7a3a8" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Audit all Kibana pages for consistency of stylistic changes - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ ### Identify risks ~~Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.~~ ~~Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.~~ - ~~[ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)~~ - ~~[ ] ...~~ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co> Co-authored-by: Jorge Oliveira <jorge.oliveira@elastic.co> Co-authored-by: ek-so <eksomail@gmail.com> Co-authored-by: Kate Sosedova <36230123+ek-so@users.noreply.github.com>
## Summary In #245898, a regression was added that prevented the vertical scrollbar from being shown in the application container in Kibana. This PR fixes the issue: * Undoing the styles that hid the scrollbar * Address the root cause of when the scrollbar was showing for unwanted reasons - the border around the application container that is added for dark mode. Related discussion: * #245898 (comment) * #243289 (comment) ### Screenshots * **Scroll bar in Observability space, light mode** <img width="1799" height="1043" alt="image" src="https://github.com/user-attachments/assets/724dd433-a641-476b-aacf-363c319ca8d0" /> * **Scroll bar in Observability space, dark mode** <img width="1807" height="1045" alt="image" src="https://github.com/user-attachments/assets/77547470-2115-403c-8c64-48a5073f35b8" /> * Scroll bar in Classic space, light mode: <img width="903" height="522" alt="image" src="https://github.com/user-attachments/assets/9704d51d-c0dd-425d-b751-0f6b6ef23fd9" /> * Scroll bar in Classic space, dark mode: <img width="1801" height="1042" alt="image" src="https://github.com/user-attachments/assets/ec597bb8-6400-4b72-8635-334b7401ddf4" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - ~~[ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ ### Identify risk - [x] Now that there is not a proper `border` on the application container, and an `outline` instead, older browsers may not support having the `border-radius` rule on the container. This risk is mitigated by doing full cross-browser testing, testing in light and dark mode, and testing the pages with browser zoom set to 400%. --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
## Summary In elastic#245898, a regression was added that prevented the vertical scrollbar from being shown in the application container in Kibana. This PR fixes the issue: * Undoing the styles that hid the scrollbar * Address the root cause of when the scrollbar was showing for unwanted reasons - the border around the application container that is added for dark mode. Related discussion: * elastic#245898 (comment) * elastic#243289 (comment) ### Screenshots * **Scroll bar in Observability space, light mode** <img width="1799" height="1043" alt="image" src="https://github.com/user-attachments/assets/724dd433-a641-476b-aacf-363c319ca8d0" /> * **Scroll bar in Observability space, dark mode** <img width="1807" height="1045" alt="image" src="https://github.com/user-attachments/assets/77547470-2115-403c-8c64-48a5073f35b8" /> * Scroll bar in Classic space, light mode: <img width="903" height="522" alt="image" src="https://github.com/user-attachments/assets/9704d51d-c0dd-425d-b751-0f6b6ef23fd9" /> * Scroll bar in Classic space, dark mode: <img width="1801" height="1042" alt="image" src="https://github.com/user-attachments/assets/ec597bb8-6400-4b72-8635-334b7401ddf4" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - ~~[ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ ### Identify risk - [x] Now that there is not a proper `border` on the application container, and an `outline` instead, older browsers may not support having the `border-radius` rule on the container. This risk is mitigated by doing full cross-browser testing, testing in light and dark mode, and testing the pages with browser zoom set to 400%. --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
## Summary In elastic#245898, a regression was added that prevented the vertical scrollbar from being shown in the application container in Kibana. This PR fixes the issue: * Undoing the styles that hid the scrollbar * Address the root cause of when the scrollbar was showing for unwanted reasons - the border around the application container that is added for dark mode. Related discussion: * elastic#245898 (comment) * elastic#243289 (comment) ### Screenshots * **Scroll bar in Observability space, light mode** <img width="1799" height="1043" alt="image" src="https://github.com/user-attachments/assets/724dd433-a641-476b-aacf-363c319ca8d0" /> * **Scroll bar in Observability space, dark mode** <img width="1807" height="1045" alt="image" src="https://github.com/user-attachments/assets/77547470-2115-403c-8c64-48a5073f35b8" /> * Scroll bar in Classic space, light mode: <img width="903" height="522" alt="image" src="https://github.com/user-attachments/assets/9704d51d-c0dd-425d-b751-0f6b6ef23fd9" /> * Scroll bar in Classic space, dark mode: <img width="1801" height="1042" alt="image" src="https://github.com/user-attachments/assets/ec597bb8-6400-4b72-8635-334b7401ddf4" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - ~~[ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ ### Identify risk - [x] Now that there is not a proper `border` on the application container, and an `outline` instead, older browsers may not support having the `border-radius` rule on the container. This risk is mitigated by doing full cross-browser testing, testing in light and dark mode, and testing the pages with browser zoom set to 400%. --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Summary
Update the look and feel of the Solution chrome.
Epic: https://github.com/elastic/kibana-team/issues/2106
Includes #245099
Changes:
Spacing when the navigation side panel shows (conditionally)
Things to test
Screenshots
Before
After
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.[ ] Flaky Test Runner was used on any tests changed[ ] The PR description includes the appropriate Release Notes section, and the correctrelease_note:*label is applied per the guidelines[ ] Review the backport guidelines and apply applicablebackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.[ ] See some risk examples[ ] ...