[ML] Fixing results for unknown fields #24577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
alvarezmelissa87,
peteharverson and
walterra
Contributor
|
Pinging @elastic/ml-ui |
droberts195
reviewed
Oct 25, 2018
| return field; | ||
| } else { | ||
| // field is not in the field stats | ||
| // this could be a text field or a field which the endpoint has |
There was a problem hiding this comment.
It should be "this could be the message field for a semi-structured log file or a field which the endpoint has"
| return { | ||
| name: fName, | ||
| name: name, | ||
| type, |
Contributor
There was a problem hiding this comment.
Nit 🕸 could be just name
jgowdyelastic
changed the title
peteharverson
approved these changes
Oct 25, 2018
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
One question. Otherwise LGTM
| EuiBetaBadge, | ||
| } from '@elastic/eui'; | ||
|
|
||
| export function ExperimentalBadge({ tooltipContent }) { |
Contributor
There was a problem hiding this comment.
Could you apply a className directly to EuiBetaBadge to achieve the same result here?
Member
Author
There was a problem hiding this comment.
the css would need to be in a shared location. so i decided it would be easier to just create a shared component instead to make it obvious that it's being overridden.
peteharverson
changed the title
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Oct 30, 2018
* [Ml] Fixing results for known fields * renaming known-type to unknown * correcting comments * tiny refactor
jgowdyelastic
added a commit
that referenced
this pull request
Oct 30, 2018
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Oct 31, 2018
* [Ml] Fixing results for known fields * renaming known-type to unknown * correcting comments * tiny refactor
jgowdyelastic
added a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the displaying of fields.
field_statsand so are then missing from the field list.Also tweaks the style of the experimental badge to make it smaller and less intrusive.