Address @elastic/eui/require-table-caption lint violations across @elastic/kibana-esql files
#245655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@elastic/kibana-esql` files
alexwizp
added
backport:all-open
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
sddonne
reviewed
Dec 10, 2025
Contributor
sddonne
left a comment
sddonne
left a comment
There was a problem hiding this comment.
This file is a couple of hours from disappearing, I prefer closing this PR rather than generating a conflict in the one that's about to be merged. 🙏
Contributor
|
Awesome, yes let's not merge Alex, unless you want to only create the backports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/require-table-caption.This rule ensure
EuiInMemoryTable,EuiBasicTablehave atableCaptionprop for accessibility.Changes
tableCaptionattributes to elements flagged by@elastic/eui/require-table-caption— accessibility leveled up!Related
@elastic/eslint-plugin-eui] added newrequire-table-captionrule. eui#9168This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team!