Skip to content

[Actionable Obs] - Update alert table muting icon to rely on the alert doc #245514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkanout wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Actionable Obs] - Update alert table muting icon to rely on the alert doc #245514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions x-pack/platform/packages/shared/response-ops/alerts-table/components/mute_alert_action.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import { EuiContextMenuItem } from '@elastic/eui';
import React, { useCallback, useMemo } from 'react';
import { i18n } from '@kbn/i18n';
import { ALERT_STATUS, ALERT_STATUS_ACTIVE } from '@kbn/rule-data-utils';
import { useMuteAlertInstance } from '@kbn/response-ops-alerts-apis/hooks/use_mute_alert_instance';
import { useUnmuteAlertInstance } from '@kbn/response-ops-alerts-apis/hooks/use_unmute_alert_instance';
Expand All @@ -29,7 +28,7 @@ export const MuteAlertAction = typedMemo(
const {
services: { http, notifications },
} = useAlertsTableContext();
const { isMuted, ruleId, rule, alertInstanceId } = useAlertMutedState(alert);
const { isMuted, ruleId, alertInstanceId } = useAlertMutedState(alert);
const { mutateAsync: muteAlert } = useMuteAlertInstance({ http, notifications });
const { mutateAsync: unmuteAlert } = useUnmuteAlertInstance({ http, notifications });
const isAlertActive = useMemo(() => alert[ALERT_STATUS]?.[0] === ALERT_STATUS_ACTIVE, [alert]);
Expand All @@ -52,19 +51,8 @@ export const MuteAlertAction = typedMemo(
}

return (
<EuiContextMenuItem
data-test-subj="toggle-alert"
onClick={toggleAlert}
size="s"
disabled={!rule}
>
{!rule
? i18n.translate('xpack.triggersActionsUI.alertsTable.loadingMutedState', {
defaultMessage: 'Loading muted state',
})
: isMuted
? UNMUTE
: MUTE}
<EuiContextMenuItem data-test-subj="toggle-alert" onClick={toggleAlert} size="s">
{isMuted ? UNMUTE : MUTE}
</EuiContextMenuItem>
);
}
Expand Down
12 changes: 5 additions & 7 deletions x-pack/platform/packages/shared/response-ops/alerts-table/hooks/use_alert_muted_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,19 @@
*/

import { useMemo } from 'react';
import { ALERT_INSTANCE_ID, ALERT_RULE_UUID } from '@kbn/rule-data-utils';
import { ALERT_INSTANCE_ID, ALERT_RULE_UUID, ALERT_MUTED } from '@kbn/rule-data-utils';
import type { Alert } from '@kbn/alerting-types';
import { useAlertsTableContext } from '../contexts/alerts_table_context';

export const useAlertMutedState = (alert?: Alert) => {
const { mutedAlerts } = useAlertsTableContext();
const alertInstanceId = alert && (alert[ALERT_INSTANCE_ID]?.[0] as string);
const ruleId = alert && (alert[ALERT_RULE_UUID]?.[0] as string);
const alertMutedValue = alert?.[ALERT_MUTED];
const isMuted = Array.isArray(alertMutedValue) && alertMutedValue[0] === true;
return useMemo(() => {
const rule = ruleId ? mutedAlerts?.[ruleId] ?? [] : [];
return {
isMuted: alertInstanceId ? rule?.includes(alertInstanceId) : null,
isMuted,
ruleId,
rule,
alertInstanceId,
};
}, [alertInstanceId, mutedAlerts, ruleId]);
}, [alertInstanceId, isMuted, ruleId]);
};
Loading