[Chrome Grid] Improve EuiBottomBar integration
#244868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:skip
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
ek-so
approved these changes
Dec 2, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Dec 2, 2025
## Summary fix elastic#242893 With the grid layout, the bottom bar could have overlapped the content area. This PR fixes it by adding padding to the content area equal to the height of the bottom bar, which pushes the content up. This is possible now due to elastic/eui#9211 ### Before: <img width="1509" height="261" alt="Screenshot 2025-12-02 at 10 55 53" src="https://github.com/user-attachments/assets/5edb3b98-9005-47b2-9c00-0fb9bc7fca51" /> ### After: <img width="1512" height="325" alt="Screenshot 2025-12-02 at 10 55 33" src="https://github.com/user-attachments/assets/604a69a7-fa86-4787-b87e-313eb01607f0" />
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
## Summary fix elastic#242893 With the grid layout, the bottom bar could have overlapped the content area. This PR fixes it by adding padding to the content area equal to the height of the bottom bar, which pushes the content up. This is possible now due to elastic/eui#9211 ### Before: <img width="1509" height="261" alt="Screenshot 2025-12-02 at 10 55 53" src="https://github.com/user-attachments/assets/5edb3b98-9005-47b2-9c00-0fb9bc7fca51" /> ### After: <img width="1512" height="325" alt="Screenshot 2025-12-02 at 10 55 33" src="https://github.com/user-attachments/assets/604a69a7-fa86-4787-b87e-313eb01607f0" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #242893
With the grid layout, the bottom bar could have overlapped the content area. This PR fixes it by adding padding to the content area equal to the height of the bottom bar, which pushes the content up. This is possible now due to elastic/eui#9211
Before:
After: