[8.19] Expose isRetryableEsClientError (#228315)#244762
Merged
rudolf merged 9 commits intoelastic:8.19from Dec 23, 2025
Merged
Conversation
## Summary For plugins to have robust error handling they need to retry transient errors. This PR exposes `isRetryableEsClientError` utility to help plugins know which errors are safe to retry. ## Note for reviewers Core's isRetryableEsClientError typically retries on more status codes than what most plugins do. Instead of keeping the existing plugin status codes I've adopted the default behavior which means your plugins will be retrying on more types of responses after this change. Carefully check that this makes sense. In particular the two following status codes get retried that plugins weren't previously retrying: * - 429 TooManyRequests (ES circuit breaker) * - 504 GatewayTimeout (rare, but happens if cloud proxy cannot establish socket connection to ES due to ES thread pool being overloaded) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c499684) # Conflicts: # src/core/packages/elasticsearch/server-internal/src/is_scripting_enabled.test.ts # src/core/packages/saved-objects/migration-server-internal/src/actions/catch_retryable_es_client_errors.ts # x-pack/platform/plugins/shared/alerting/tsconfig.json # x-pack/platform/plugins/shared/cases/server/cases_analytics/tasks/synchronization_task/synchronization_sub_task.ts # x-pack/platform/plugins/shared/cases/server/cases_analytics/utils.ts # x-pack/platform/plugins/shared/cases/tsconfig.json # x-pack/platform/plugins/shared/streams/tsconfig.json # x-pack/solutions/observability/plugins/observability/tsconfig.json # x-pack/solutions/observability/plugins/slo/tsconfig.json # x-pack/solutions/security/plugins/security_solution/tsconfig.json
10 tasks
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
gsoldevila
approved these changes
Dec 22, 2025
Contributor
gsoldevila
left a comment
gsoldevila
left a comment
There was a problem hiding this comment.
Pre-approving hoping for green CI
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation