[Detections & Response] RBAC - Add Detection Alerts kibana feature #244637
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import type { ProductFeatureAlertsKey } from '../product_features_keys'; | ||
| import { getAlertsBaseKibanaFeature } from './kibana_features'; | ||
| import type { ProductFeatureParams } from '../types'; | ||
| import { alertsDefaultProductFeaturesConfig } from './product_feature_config'; | ||
|
|
||
| export const getAlertsFeature = (): ProductFeatureParams<ProductFeatureAlertsKey, string> => ({ | ||
|
Contributor
There was a problem hiding this comment. I wonder whether we should comment on what a security feature does. We have increasing number of security features where the boundary might be not 100% clear. There is a Google Sheet(s) describing the behavior but it lives separately. A comment could make the description clearer to the code. WDYT?
Contributor
|
||
| baseKibanaFeature: getAlertsBaseKibanaFeature(), | ||
| baseKibanaSubFeatureIds: [], | ||
| subFeaturesMap: new Map(), | ||
| productFeatureConfig: alertsDefaultProductFeaturesConfig, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { DEFAULT_APP_CATEGORIES } from '@kbn/core-application-common'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { SECURITY_SOLUTION_RULE_TYPE_IDS } from '@kbn/securitysolution-rules'; | ||
| import { DATA_VIEW_SAVED_OBJECT_TYPE } from '@kbn/data-views-plugin/common'; | ||
| import { | ||
| ALERTS_API_ALL, | ||
| ALERTS_API_READ, | ||
| APP_ID, | ||
| LEGACY_NOTIFICATIONS_ID, | ||
| ALERTS_FEATURE_ID, | ||
| SERVER_APP_ID, | ||
| ALERTS_UI_READ, | ||
| ALERTS_UI_EDIT, | ||
| INITIALIZE_SECURITY_SOLUTION, | ||
| USERS_API_READ, | ||
| } from '../constants'; | ||
| import { type BaseKibanaFeatureConfig } from '../types'; | ||
|
|
||
| const alertingFeatures = [LEGACY_NOTIFICATIONS_ID, ...SECURITY_SOLUTION_RULE_TYPE_IDS].map( | ||
| (ruleTypeId) => ({ | ||
| ruleTypeId, | ||
| consumers: [SERVER_APP_ID], | ||
| }) | ||
| ); | ||
|
|
||
| export const getAlertsBaseKibanaFeature = (): BaseKibanaFeatureConfig => ({ | ||
| id: ALERTS_FEATURE_ID, | ||
| name: i18n.translate( | ||
| 'securitySolutionPackages.features.featureRegistry.linkSecuritySolutionRolesAlertsTitle', | ||
| { | ||
| defaultMessage: 'Alerts', | ||
| } | ||
| ), | ||
| order: 1100, | ||
| category: DEFAULT_APP_CATEGORIES.security, | ||
| app: [ALERTS_FEATURE_ID, 'kibana', 'securitySolution'], | ||
| catalogue: [APP_ID], | ||
| alerting: alertingFeatures, | ||
| privileges: { | ||
| all: { | ||
| app: ['securitySolution', ALERTS_FEATURE_ID, 'kibana'], | ||
| catalogue: [APP_ID], | ||
| savedObject: { | ||
| all: [], | ||
| read: [DATA_VIEW_SAVED_OBJECT_TYPE], | ||
| }, | ||
| alerting: { | ||
| alert: { all: alertingFeatures }, | ||
| }, | ||
| ui: [ALERTS_UI_READ, ALERTS_UI_EDIT], | ||
| api: ['rac', INITIALIZE_SECURITY_SOLUTION, ALERTS_API_ALL, ALERTS_API_READ, USERS_API_READ], | ||
| }, | ||
| read: { | ||
| app: [ALERTS_FEATURE_ID, 'kibana', 'securitySolution'], | ||
| catalogue: [APP_ID], | ||
| savedObject: { | ||
| all: [], | ||
| read: [DATA_VIEW_SAVED_OBJECT_TYPE], | ||
| }, | ||
| alerting: { | ||
| alert: { read: alertingFeatures }, | ||
| }, | ||
| ui: [ALERTS_UI_READ], | ||
| api: ['rac', INITIALIZE_SECURITY_SOLUTION, ALERTS_API_READ, USERS_API_READ], | ||
| }, | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { ProductFeatureAlertsKey } from '../product_features_keys'; | ||
| import type { AlertsProductFeaturesConfig } from './types'; | ||
|
|
||
| export const alertsDefaultProductFeaturesConfig: AlertsProductFeaturesConfig = { | ||
| [ProductFeatureAlertsKey.externalDetections]: { | ||
| privileges: { | ||
| all: { | ||
| ui: ['external_detections'], | ||
| api: [], | ||
| }, | ||
| read: { | ||
| ui: ['external_detections'], | ||
| api: [], | ||
| }, | ||
| }, | ||
| }, | ||
| [ProductFeatureAlertsKey.detections]: { | ||
| privileges: { | ||
| all: { | ||
| ui: ['detections'], | ||
| api: ['bulkGetUserProfiles'], | ||
| }, | ||
| read: { | ||
| ui: ['detections'], | ||
| api: [], | ||
| }, | ||
| }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import type { ProductFeatureAlertsKey } from '../product_features_keys'; | ||
| import type { ProductFeaturesConfig } from '../types'; | ||
|
|
||
| export type AlertsProductFeaturesConfig = ProductFeaturesConfig<ProductFeatureAlertsKey>; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it a bug not taking
panel.itemsinto account?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's why I fixed it 😉 . However, it wasn't a bug prior to this branch, since there wasn't previously a user who could see the alerts table but lacked alert actions. I detailed this in 84c6d94.