[File upload] Redesign of the file upload section of the lookup join flyout #244550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elastic/kibana into look-up-join-file-upload-redesign
…elastic/kibana into look-up-join-file-upload-redesign
…elastic/kibana into look-up-join-file-upload-redesign
.../packages/shared/file-upload/src/file_upload_component/new/mapping_editor/mapping_editor.tsx
Outdated
Show resolved
Hide resolved
…elastic/kibana into look-up-join-file-upload-redesign
rbrtj
reviewed
Dec 10, 2025
| return; | ||
| } | ||
| pipeline.processors.push({ | ||
| pipeline.processors!.push({ |
Contributor
There was a problem hiding this comment.
nit: Maybe we could get rid of this non-null assertion by also checking for the pipeline.processors in the if above?
Contributor
There was a problem hiding this comment.
Or perhaps processors can be non-optional in x-pack/platform/packages/shared/file-upload-common/src/types.ts? I saw some more non-null assertions.
Comment on lines
72
to
74
| {i18n.translate('xpack.fileUpload.mappingEditor.fieldNameLabel', { | ||
| defaultMessage: 'Field name', | ||
| })} |
Contributor
There was a problem hiding this comment.
Suggested change
| {i18n.translate('xpack.fileUpload.mappingEditor.fieldNameLabel', { | |
| defaultMessage: 'Field name', | |
| })} | |
| <FormattedMessage {...} />``` |
Comment on lines
79
to
81
| {i18n.translate('xpack.fileUpload.mappingEditor.fieldTypeLabel', { | ||
| defaultMessage: 'Field type', | ||
| })} |
Contributor
There was a problem hiding this comment.
Suggested change
| {i18n.translate('xpack.fileUpload.mappingEditor.fieldTypeLabel', { | |
| defaultMessage: 'Field type', | |
| })} | |
| <FormattedMessage {...} />``` |
Comment on lines
+58
to
+62
| useEffect(() => { | ||
| if (uploadStatus.overallImportStatus === STATUS.COMPLETED) { | ||
| setStep('finish', STATUS.COMPLETED); | ||
| } | ||
| }, [uploadStatus.overallImportStatus, setStep]); |
Contributor
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| if (uploadStatus.overallImportStatus === STATUS.COMPLETED) { | |
| setStep('finish', STATUS.COMPLETED); | |
| } | |
| }, [uploadStatus.overallImportStatus, setStep]); | |
| const isFinished = uploadStatus.overallImportStatus === STATUS.COMPLETED; |
It would mean removing the finish step from the stepsStatus state, but we could get rid of the useEffect.
Comment on lines
68
to
79
| useEffect(() => { | ||
| setFileUploadActive(true); | ||
| return () => { | ||
| setFileUploadActive(false); | ||
| }; | ||
| }, [setFileUploadActive]); | ||
|
|
||
| useEffect(() => { | ||
| if (filesStatus.length === 0) { | ||
| setFileUploadActive(false); | ||
| } | ||
| }, [filesStatus, setFileUploadActive]); |
Contributor
There was a problem hiding this comment.
I wonder if we could combine it into one useEffect such as
Suggested change
| useEffect(() => { | |
| setFileUploadActive(true); | |
| return () => { | |
| setFileUploadActive(false); | |
| }; | |
| }, [setFileUploadActive]); | |
| useEffect(() => { | |
| if (filesStatus.length === 0) { | |
| setFileUploadActive(false); | |
| } | |
| }, [filesStatus, setFileUploadActive]); | |
| useEffect(() => { | |
| setFileUploadActive(filesStatus.length > 0); | |
| return () => { | |
| setFileUploadActive(false); | |
| }; | |
| }, [deps]); |
rbrtj
approved these changes
Dec 10, 2025
| ? uploadStatus.allDocsSearchable === true | ||
| ? STATUS.COMPLETED | ||
| : STATUS.STARTED | ||
| : stepsStatus.finish |
Contributor
There was a problem hiding this comment.
this might require an update after the recent changes, no? As the stepsStatus.finish would be always STATUS.NOT_STARTED.
Member
Author
There was a problem hiding this comment.
I've reverted this change d836641
To avoid introducing any last minute bugs
…elastic/kibana into look-up-join-file-upload-redesign
kibanamachine
added
backport:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
|
andrimal
pushed a commit
to andrimal/kibana
that referenced
this pull request
Dec 11, 2025
Remakes the file upload section of the lookup join flyout. https://github.com/user-attachments/assets/c50085d0-b4ea-47ce-8830-8fd0c509960f --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
seanrathier
pushed a commit
to seanrathier/kibana
that referenced
this pull request
Dec 15, 2025
Remakes the file upload section of the lookup join flyout. https://github.com/user-attachments/assets/c50085d0-b4ea-47ce-8830-8fd0c509960f --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
peteharverson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remakes the file upload section of the lookup join flyout.
2025-12-02.13-58-34.2025-12-02.13_59_31.mp4