Skip to content

[ES|QL] Changes in the footer of the editor#244284

Merged
stratoula merged 39 commits intoelastic:mainfrom
stratoula:query-statistics-esql-editpr
Jan 29, 2026
Merged

[ES|QL] Changes in the footer of the editor#244284
stratoula merged 39 commits intoelastic:mainfrom
stratoula:query-statistics-esql-editpr

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Nov 26, 2025

Summary

Part of #188992

Cleanups the editor, part of a redesign to focus on the query statistics (part of Discover only).

  • Removed the limit 1000 as many find it confusing
  • Removed the @timestamp found / not found
  • Added stats for the query run

It also removes the grey from the editor footer upon request

image

Also the documents queried are also present at the inspector

image

Checklist

@stratoula stratoula changed the title Remove and cleanup unecessary information [ES|QL] Changes in the editor footer, optional last run information Nov 26, 2025
@stratoula stratoula changed the title [ES|QL] Changes in the editor footer, optional last run information [ES|QL] Changes in the footer of the editor Nov 28, 2025
@stratoula stratoula force-pushed the query-statistics-esql-editpr branch from c0b66e1 to 545deb4 Compare December 1, 2025 06:24
@stratoula stratoula marked this pull request as ready for review January 28, 2026 14:14
@stratoula stratoula requested review from a team as code owners January 28, 2026 14:14
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

Copy link
Copy Markdown
Contributor

@sddonne sddonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread src/platform/plugins/shared/data/common/search/expressions/esql.ts Outdated
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM. Code only review as it's a simple prop addition to the unified search bar.

Comment thread src/platform/plugins/shared/data/common/search/expressions/esql.ts Outdated
@stratoula stratoula enabled auto-merge (squash) January 29, 2026 14:23
@stratoula stratoula merged commit ac17acb into elastic:main Jan 29, 2026
16 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #95 / Cloud Security Posture Agentless cloud Hyperlink on PostInstallation Modal should have the correct URL

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 2070 2071 +1
esql 531 533 +2
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-types 125 129 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 547.0KB 547.0KB -22.0B
dataVisualizer 602.9KB 602.9KB -49.0B
discover 1.5MB 1.5MB +590.0B
esql 737.0KB 736.0KB -1010.0B
lens 2.0MB 2.0MB -190.0B
securitySolution 10.8MB 10.8MB -22.0B
stackAlerts 69.3KB 69.2KB -54.0B
unifiedSearch 362.8KB 362.7KB -85.0B
total -842.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 443.6KB 444.0KB +338.0B
esql 16.3KB 16.3KB +1.0B
unifiedSearch 17.9KB 17.9KB +32.0B
total +371.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-types 131 140 +9

History

hannahbrooks pushed a commit to hannahbrooks/kibana that referenced this pull request Jan 30, 2026
## Summary

Part of elastic#188992

Cleanups the editor, part of a redesign to focus on the query statistics
(part of Discover only).

- Removed the limit 1000 as many find it confusing
- Removed the @timestamp found / not found
- Added stats for the query run


It also removes the grey from the editor footer upon request

<img width="2502" height="450" alt="image"
src="https://github.com/user-attachments/assets/d793c587-e7dd-426d-85ad-1f1be98136bf"
/>


Also the documents queried are also present at the inspector

<img width="834" height="267" alt="image"
src="https://github.com/user-attachments/assets/850b5fa9-57d4-4d75-8018-acadcc2f8000"
/>


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.