-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Alerting] Show workflow tags on table and details page #244251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Show workflow tags on table and details page #244251
Conversation
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/actionable-obs-team (Team:actionable-obs) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
629146a to
1918cb0
Compare
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first pass, need to checkout locally.
...ns/observability/plugins/observability/public/components/alerts_table/common/get_columns.tsx
Outdated
Show resolved
Hide resolved
| <EuiFlexItem grow={false}> | ||
| <TagsList tags={tags} ignoreEmpty color="default" /> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem grow={false}> | ||
| <TagsList tags={workflowTags} ignoreEmpty color="default" /> | ||
| </EuiFlexItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to separate them here simply because they're separated on the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a label before the tags like "Workflow tags: <the_tags>"? Maybe we need design input here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed here
|
I did a quick pass. LGTM. The only thing I noticed is that if I have configured the columns before this PR, the workflow column will not be shown. Nothing related to this PR, but maybe we need to consider addressing it at the framework level. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9954[✅] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 25/25 tests passed. |
smith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra UI changes look good!
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
## Summary Closes elastic#240377 Closes elastic#240376 (with [this PR](elastic#243792)) <img width="1467" height="297" alt="Screenshot 2025-11-25 at 5 20 01 PM" src="https://github.com/user-attachments/assets/124ab28e-db22-4bc8-914d-31088930afea" /> <img width="1469" height="640" alt="Screenshot 2025-11-25 at 5 18 06 PM" src="https://github.com/user-attachments/assets/0a4874e1-6fbf-4355-a8b8-8d26c68b8492" /> ## Release Notes Users can now view and filter by workflow tags manually added to alerts --------- Co-authored-by: Faisal Kanout <[email protected]>
## Release Notes Users can now manually add workflow tags directly to alerts (see [this PR as well](#244251)) ## Summary Part of #240376 - Adds "Edit tags" in alert actions - Opens flyout when clicking on "Edit tags" - Flyout shows list of all `kibana.alert.workflow_tags` from the selected alerts - "Edit tags" will be disabled when all alerts are selected (as there can be 1000s of alerts with many tags) - "Edit tags" will not be available for Security rules --------- Co-authored-by: Bailey Cash <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Christos Nasikas <[email protected]>
## Summary Closes elastic#240377 Closes elastic#240376 (with [this PR](elastic#243792)) <img width="1467" height="297" alt="Screenshot 2025-11-25 at 5 20 01 PM" src="https://github.com/user-attachments/assets/124ab28e-db22-4bc8-914d-31088930afea" /> <img width="1469" height="640" alt="Screenshot 2025-11-25 at 5 18 06 PM" src="https://github.com/user-attachments/assets/0a4874e1-6fbf-4355-a8b8-8d26c68b8492" /> ## Release Notes Users can now view and filter by workflow tags manually added to alerts --------- Co-authored-by: Faisal Kanout <[email protected]>
## Release Notes Users can now manually add workflow tags directly to alerts (see [this PR as well](elastic#244251)) ## Summary Part of elastic#240376 - Adds "Edit tags" in alert actions - Opens flyout when clicking on "Edit tags" - Flyout shows list of all `kibana.alert.workflow_tags` from the selected alerts - "Edit tags" will be disabled when all alerts are selected (as there can be 1000s of alerts with many tags) - "Edit tags" will not be available for Security rules --------- Co-authored-by: Bailey Cash <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Christos Nasikas <[email protected]>

Summary
Closes #240377
Closes #240376 (with this PR)
Release Notes
Users can now view and filter by workflow tags manually added to alerts