Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Nov 20, 2025

Summary

There is a meaningful fix already on: #243612

It's going into 9.3 and cannot be backported because it relies on latest EUI updates (v109.1.0), specifically:

Fixed an issue where portalled components like EuiPopover were not included in EuiFlyout's focus trap through includeSelectorInFocusTrap, making them inaccessible to keyboard users (elastic/eui#9103)

QA

Flyouts

Kapture.2025-11-20.at.16.38.23.mp4

Security PageOverlay

Kapture.2025-11-20.at.17.08.57.mp4

Keyboard navigation

Kapture.2025-11-20.at.16.36.40.mp4

@weronikaolejniczak weronikaolejniczak self-assigned this Nov 20, 2025
@weronikaolejniczak weronikaolejniczak added EUI backport:skip This PR does not require backporting release_note:fix labels Nov 20, 2025
Call `handleBlur` conditionally for `PageOverlay`, otherwise the popover closes and menu items don't trigger.
@weronikaolejniczak weronikaolejniczak force-pushed the fix/security-page-layout-quick-fix branch from 2c07e39 to ebe2e69 Compare November 20, 2025 16:11
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review November 20, 2025 16:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@Dosant
Copy link
Contributor

Dosant commented Nov 20, 2025

Thanks, will test tomorrow

@Dosant Dosant requested a review from ashokaditya November 20, 2025 17:16
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 131.0KB 131.1KB +66.0B

cc @weronikaolejniczak

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this but I see new issues with overlay below the nav. See clips from alerts details and from endpoints page. 😓

Image
Image

@weronikaolejniczak
Copy link
Contributor Author

weronikaolejniczak commented Nov 21, 2025

@ashokaditya grid layout is not available in 9.2. I'd recommend removing the feature toggle, re-test and all should be good 👌🏻

@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) November 21, 2025 10:42
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested sidenav+flyouts in chrome and safari

@weronikaolejniczak weronikaolejniczak merged commit 5ce2d61 into elastic:9.2 Nov 21, 2025
12 checks passed
@ashokaditya
Copy link
Member

@weronikaolejniczak I tested again without the gridLayout feature flag and response console works as expected. 👍🏻
Sorry for the confusion earlier where I tested the 9.2 branch with the feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants