Skip to content

[Chrome] Grid Layout by default #243181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dosant merged 1 commit into from
Nov 24, 2025
Merged

[Chrome] Grid Layout by default #243181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/packages/chrome/browser-mocks/src/chrome_service.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const createStartContractMock = () => {
navigationTourManager: {} as any,
}),
setGlobalFooter: jest.fn(),
getGlobalFooter$: jest.fn(),
getGlobalFooter$: jest.fn().mockReturnValue(new BehaviorSubject(null)),
});

return startContract;
Expand Down
2 changes: 1 addition & 1 deletion src/core/packages/chrome/layout/core-chrome-layout-feature-flags/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const LAYOUT_DEBUG_FEATURE_FLAG_KEY = 'core.chrome.layoutDebug';
export const getLayoutVersion = (featureFlags: FeatureFlagsStart): LayoutFeatureFlag => {
const featureFlag = featureFlags.getStringValue<LayoutFeatureFlag>(
LAYOUT_FEATURE_FLAG_KEY,
'legacy-fixed'
'grid'
);
if (featureFlag !== 'legacy-fixed' && featureFlag !== 'grid') {
throw new Error(
Expand Down
2 changes: 1 addition & 1 deletion src/core/packages/rendering/browser-internal/src/rendering_service.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('RenderingService', () => {
application.getComponent.mockReturnValue(<div>Hello application!</div>);

chrome = chromeServiceMock.createStartContract();
chrome.getLegacyHeaderComponentForFixedLayout.mockReturnValue(<div>Hello chrome!</div>);
chrome.getClassicHeaderComponentForGridLayout.mockReturnValue(<div>Hello chrome!</div>);

overlays = overlayServiceMock.createStartContract();
overlays.banners.getComponent.mockReturnValue(<div>I&apos;m a banner!</div>);
Expand Down
6 changes: 6 additions & 0 deletions src/platform/packages/shared/react/kibana_context/root/eui_provider.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ describe('KibanaEuiProvider', () => {
EuiFlyout: {
includeSelectorInFocusTrap: euiIncludeSelectorInFocusTrap.selector,
},
EuiPopover: {
repositionOnScroll: true,
},
EuiToolTip: {
repositionOnScroll: true,
},
},
}),
expect.anything()
Expand Down
6 changes: 6 additions & 0 deletions src/platform/packages/shared/react/kibana_context/root/eui_provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ const componentDefaults: EuiProviderProps<unknown>['componentDefaults'] = {
EuiFlyout: {
includeSelectorInFocusTrap: `[data-eui-includes-in-flyout-focus-trap="true"]`,
},
EuiPopover: {
repositionOnScroll: true,
},
EuiToolTip: {
repositionOnScroll: true,
},
};

/**
Expand Down
10 changes: 6 additions & 4 deletions x-pack/platform/plugins/shared/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,12 @@ describe(
cy.contains('Custom key/value pairs. e.g. {"application":"foo-bar","env":"production"}');
cy.contains('Days of uptime');
});
cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
cy.getBySel('comboBoxSearchInput').should('have.value', packName);
cy.getBySel('comboBoxInput').type('{selectall}{backspace}{enter}');
});
cy.getBySel(RESPONSE_ACTIONS_ITEM_1)
.within(() => {
cy.getBySel('comboBoxSearchInput').should('have.value', packName);
cy.getBySel('comboBoxInput').type('{selectall}{backspace}{enter}');
})
.clickOutside();
cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
cy.contains('select * from uptime1');
cy.getBySel('remove-response-action').click();
Expand Down
1 change: 0 additions & 1 deletion ...k/solutions/observability/test/functional_solution_sidenav/tests/observability_sidenav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
}

// open Infrastructure popover and navigate to some link inside the panel
await solutionNavigation.sidenav.expandMore();
Copy link
Contributor Author

@Dosant Dosant Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a bit more space for the sidenav now, so the "infra" is not under "more" anymore in ftr tests

await solutionNavigation.sidenav.clickLink({ navId: 'metrics' });
// open first link in popover to open a panel
await solutionNavigation.sidenav.clickLink({ navId: 'metrics:inventory' });
Expand Down
1 change: 0 additions & 1 deletion x-pack/solutions/observability/test/serverless/functional/test_suites/infra/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const pageObjects = getPageObjects(['svlCommonPage', 'svlCommonNavigation', 'header']);

const openInfraSection = async () => {
await pageObjects.svlCommonNavigation.sidenav.expandMore();
await pageObjects.svlCommonNavigation.sidenav.openPanel('metrics');
};

Expand Down