Revert "[SLO] Fix issue where filters do not apply to overview stats"#242978
Merged
baileycash-elastic merged 2 commits intomainfrom Nov 17, 2025
Merged
Revert "[SLO] Fix issue where filters do not apply to overview stats"#242978baileycash-elastic merged 2 commits intomainfrom
baileycash-elastic merged 2 commits intomainfrom
Conversation
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
github-actions
bot
added
the
author:obs-ux-management
jasonrhodes
added
release_note:fix
backport:version
baileycash-elastic
approved these changes
Nov 13, 2025
Member
Author
|
@baileycash-elastic were you able to run this locally with latest to confirm it doesn't have any weird problems with things that came after this PR? I would hope not but just making sure we checked, I haven't run it locally yet. I will. |
Contributor
This one is fairly isolated and is used in only one place. Tested it, works as expected. Unfortunately 🥲 |
jasonrhodes
force-pushed
the
revert-234218-slo-233631
branch
from
47e150b to
1940574
Compare
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
Contributor
|
Starting backport for target branches: 9.2 https://github.com/elastic/kibana/actions/runs/19425573961 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2025
…elastic#242978) Reverts elastic#234218 This PR adds a composite aggregation do/while loop that attempts to retreive ALL SLO instances, which in some cases can be upwards of 1M records or more, and can cause significant performance strains on a cluster. We should rethink the approach here when we have time to do that. (cherry picked from commit 9cc4742)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2025
…stats" (#242978) (#243164) # Backport This will backport the following commits from `main` to `9.2`: - [Revert "[SLO] Fix issue where filters do not apply to overview stats" (#242978)](#242978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jason Rhodes","email":"jason.rhodes@elastic.co"},"sourceCommit":{"committedDate":"2025-11-17T09:59:35Z","message":"Revert \"[SLO] Fix issue where filters do not apply to overview stats\" (#242978)\n\nReverts #234218\n\nThis PR adds a composite aggregation do/while loop that attempts to\nretreive ALL SLO instances, which in some cases can be upwards of 1M\nrecords or more, and can cause significant performance strains on a\ncluster. We should rethink the approach here when we have time to do\nthat.","sha":"9cc47422091a66e2668dcbd025b9b8795962cc62","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.3.0","v9.2.2"],"title":"Revert \"[SLO] Fix issue where filters do not apply to overview stats\"","number":242978,"url":"https://github.com/elastic/kibana/pull/242978","mergeCommit":{"message":"Revert \"[SLO] Fix issue where filters do not apply to overview stats\" (#242978)\n\nReverts #234218\n\nThis PR adds a composite aggregation do/while loop that attempts to\nretreive ALL SLO instances, which in some cases can be upwards of 1M\nrecords or more, and can cause significant performance strains on a\ncluster. We should rethink the approach here when we have time to do\nthat.","sha":"9cc47422091a66e2668dcbd025b9b8795962cc62"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242978","number":242978,"mergeCommit":{"message":"Revert \"[SLO] Fix issue where filters do not apply to overview stats\" (#242978)\n\nReverts #234218\n\nThis PR adds a composite aggregation do/while loop that attempts to\nretreive ALL SLO instances, which in some cases can be upwards of 1M\nrecords or more, and can cause significant performance strains on a\ncluster. We should rethink the approach here when we have time to do\nthat.","sha":"9cc47422091a66e2668dcbd025b9b8795962cc62"}},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jason Rhodes <jason.rhodes@elastic.co> Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…elastic#242978) Reverts elastic#234218 This PR adds a composite aggregation do/while loop that attempts to retreive ALL SLO instances, which in some cases can be upwards of 1M records or more, and can cause significant performance strains on a cluster. We should rethink the approach here when we have time to do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #234218
This PR adds a composite aggregation do/while loop that attempts to retreive ALL SLO instances, which in some cases can be upwards of 1M records or more, and can cause significant performance strains on a cluster. We should rethink the approach here when we have time to do that.