[Core] Remove URL Overflow & Deprecate storeInSessionStorage setting

docs/reference/advanced-settings.md

@@ -70,7 +70,7 @@ $$$datenanosformat$$$`dateNanosFormat` {applies_to}`stack: ga` {applies_to}`serv
 $$$theme-darkmode$$$`theme:darkMode` {applies_to}`stack: deprecated 9.0` {applies_to}`serverless: unavailable`
 :   The UI theme that the {{product.kibana}} UI should use. Set to `enabled` or `disabled` to enable or disable the dark theme. Set to `system` to have the {{product.kibana}} UI theme follow the system theme. You must refresh the page to apply the setting.
 
-$$$state-storeinsessionstorage$$$`state:storeInSessionStorage` {applies_to}`stack: preview` {applies_to}`serverless: unavailable`
+$$$state-storeinsessionstorage$$$`state:storeInSessionStorage` {applies_to}`stack: preview 9.0-9.3, deprecated 9.4+` {applies_to}`serverless: unavailable`
 :   {{product.kibana}} tracks UI state in the URL, which can lead to problems when there is a lot of state information, and the URL gets long. Enabling this setting stores part of the URL in your browser session to keep the URL short.
 
 $$$savedobjects-perpage$$$`savedObjects:perPage` {applies_to}`stack: ga` {applies_to}`serverless: unavailable`

src/core/moon.yml

@@ -24,7 +24,6 @@ dependsOn:
   - '@kbn/core-application-browser'
   - '@kbn/core-application-browser-internal'
   - '@kbn/core-saved-objects-common'
-  - '@kbn/core-apps-browser-internal'
   - '@kbn/core-root-browser-internal'
   - '@kbn/core-theme-browser-mocks'
   - '@kbn/core-base-browser-mocks'

src/core/packages/apps/browser-internal/index.ts

@@ -7,5 +7,5 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export { CoreAppsService, URL_MAX_LENGTH } from './src';
+export { CoreAppsService } from './src';
 export type { CoreAppsServiceSetupDeps, CoreAppsServiceStartDeps } from './src';

src/core/packages/apps/browser-internal/moon.yml

@@ -32,7 +32,6 @@ dependsOn:
   - '@kbn/core-http-browser-internal'
   - '@kbn/core-application-browser-mocks'
   - '@kbn/core-notifications-browser-mocks'
-  - '@kbn/core-ui-settings-browser-mocks'
   - '@kbn/core-http-browser-mocks'
   - '@kbn/core-metrics-collectors-server-mocks'
   - '@kbn/core-status-common'

src/core/packages/apps/browser-internal/src/core_app.ts

@@ -6,8 +6,6 @@
  * your election, the "Elastic License 2.0", the "GNU Affero General Public
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
-
-import type { UnregisterCallback } from 'history';
 import type { CoreContext } from '@kbn/core-base-browser-internal';
 import type { InternalInjectedMetadataSetup } from '@kbn/core-injected-metadata-browser-internal';
 import type { DocLinksStart } from '@kbn/core-doc-links-browser';
@@ -24,11 +22,7 @@ import type { I18nStart } from '@kbn/core-i18n-browser';
 import type { ThemeServiceStart } from '@kbn/core-theme-browser';
 import type { UserProfileService } from '@kbn/core-user-profile-browser';
 import { renderApp as renderStatusApp } from './status';
-import {
-  renderApp as renderErrorApp,
-  setupPublicBaseUrlConfigWarning,
-  setupUrlOverflowDetection,
-} from './errors';
+import { renderApp as renderErrorApp, setupPublicBaseUrlConfigWarning } from './errors';
 
 export interface CoreAppsServiceSetupDeps {
   application: InternalApplicationSetup;
@@ -50,8 +44,6 @@ export interface CoreAppsServiceStartDeps {
 }
 
 export class CoreAppsService {
-  private stopHistoryListening?: UnregisterCallback;
-
   constructor(private readonly coreContext: CoreContext) {}
 
   public setup({ application, http, injectedMetadata, notifications }: CoreAppsServiceSetupDeps) {
@@ -94,20 +86,8 @@ export class CoreAppsService {
       return;
     }
 
-    this.stopHistoryListening = setupUrlOverflowDetection({
-      basePath: http.basePath,
-      history: application.history,
-      toasts: notifications.toasts,
-      uiSettings,
-    });
-
     setupPublicBaseUrlConfigWarning({ docLinks, http, notifications, ...startDeps });
   }
 
-  public stop() {
-    if (this.stopHistoryListening) {
-      this.stopHistoryListening();
-      this.stopHistoryListening = undefined;
-    }
-  }
+  public stop() {}
 }

src/core/packages/apps/browser-internal/src/errors/error_application.test.ts

@@ -48,14 +48,4 @@ describe('renderApp', () => {
       `"Application error"`
     );
   });
-
-  it('renders urlOverflow errors', () => {
-    act(() => {
-      history.push('/app/error?errorType=urlOverflow');
-    });
-    expect(element.querySelector('.euiTitle')!.innerHTML).toMatchInlineSnapshot(
-      `"The URL for this object is too long, and we can't display it"`
-    );
-    expect(element.innerHTML).toMatch('Things to try');
-  });
 });

src/core/packages/apps/browser-internal/src/errors/error_application.tsx

@@ -18,7 +18,6 @@ import { EuiPageTemplate } from '@elastic/eui';
 import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
 import type { IBasePath } from '@kbn/core-http-browser';
 import type { AppMountParameters } from '@kbn/core-application-browser';
-import { UrlOverflowUi } from './url_overflow_ui';
 
 interface Props {
   title?: string;
@@ -45,26 +44,11 @@ const ErrorPage: React.FC<Props> = ({ title, children }) => {
 };
 
 const ErrorApp: React.FC<{ basePath: IBasePath; history: History }> = ({ basePath, history }) => {
-  const [currentLocation, setCurrentLocation] = useState(history.location);
+  const [, setCurrentLocation] = useState(history.location);
   useLayoutEffect(() => {
     return history.listen((location) => setCurrentLocation(location));
   }, [history]);
 
-  const searchParams = new URLSearchParams(currentLocation.search);
-  const errorType = searchParams.get('errorType');
-
-  if (errorType === 'urlOverflow') {
-    return (
-      <ErrorPage
-        title={i18n.translate('core.ui.errorUrlOverflow.errorTitle', {
-          defaultMessage: "The URL for this object is too long, and we can't display it",
-        })}
-      >
-        <UrlOverflowUi basePath={basePath} />
-      </ErrorPage>
-    );
-  }
-
   return <ErrorPage />;
 };
 

src/core/packages/apps/browser-internal/src/errors/index.ts

@@ -8,5 +8,4 @@
  */
 
 export { renderApp } from './error_application';
-export { setupUrlOverflowDetection, URL_MAX_LENGTH } from './url_overflow';
 export { setupPublicBaseUrlConfigWarning } from './public_base_url';