-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Add new gap fill status for rules #242595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
80b48fa
Add aggregated ap status
nkhristinin ceb9efb
Changes from yarn openapi:bundle
kibanamachine fa4df71
fix ci
nkhristinin 14d3aa1
Changes from make api-docs
kibanamachine 2563e6d
add aggregated status in query
nkhristinin ae8957a
fix tests
nkhristinin c2875a8
add persistence logic
nkhristinin e855c2c
Merge branch 'rules-with-gap-status' of github.com:nkhristinin/kibana…
nkhristinin 45be9ce
fix tests
nkhristinin 7487c87
return aggs names
nkhristinin 866502b
clean up
nkhristinin fff6356
fix open api
nkhristinin 9bd2edd
clean up
nkhristinin ac40100
Changes from yarn openapi:bundle
kibanamachine ba4dac0
Changes from make api-docs
kibanamachine 7823b31
Merge branch 'main' into rules-with-gap-status
elasticmachine b298b8f
fix tests
nkhristinin 161fce4
Merge branch 'rules-with-gap-status' of github.com:nkhristinin/kibana…
nkhristinin ea6761d
Merge branch 'main' into rules-with-gap-status
elasticmachine 7fea0ee
make 90 days default gap range
nkhristinin 781f918
Merge branch 'rules-with-gap-status' of github.com:nkhristinin/kibana…
nkhristinin cc5d324
Change in DE aggregated gap status to gap fill status
nkhristinin 56f8f33
Rename to GapFillStatus
nkhristinin 58a564c
Changes from yarn openapi:bundle
kibanamachine 5ef908e
Changes from make api-docs
kibanamachine d6acab4
Rename to highest priority gap gill status
nkhristinin db21de9
Merge branch 'main' into rules-with-gap-status
elasticmachine d023c10
Rename to gap fill status in response
nkhristinin f20f19e
Merge branch 'rules-with-gap-status' of github.com:nkhristinin/kibana…
nkhristinin 4bf14ea
Add comments for statuses
nkhristinin 5d0d8d4
Split unit tests
nkhristinin 40fa19b
Derrive GapDurationBucket from RULE_GAP_AGGREGATIONS
nkhristinin db3ca63
Set default value for highestPriorityGapFillStatuses
nkhristinin 323160a
Remove default undefined value
nkhristinin 9010034
Extract hasMatchedGapFillStatus to utils function
nkhristinin 2d9a134
Use common types for aggregations
nkhristinin ab090dc
Don't use empty string by deafult for gap_fill_status
nkhristinin 2b777c7
Use use boolean
nkhristinin 806f4c1
Use a common tyoe for gap fill status column
nkhristinin 7ac3e51
Extract gap fill status tooltip into different component
nkhristinin 1af566f
Align validation
nkhristinin 595db05
Extract gap params to another function, to remove complexity
nkhristinin 03800ec
fix tests
nkhristinin e7aeac4
use common enum for gap fill status
nkhristinin b9b2790
fix tests
nkhristinin 176cce6
Merge branch 'main' into rules-with-gap-status
maximpn 0a3eec8
reset gap fill status filter and not store in URL
nkhristinin c834619
Merge branch 'rules-with-gap-status' of github.com:nkhristinin/kibana…
nkhristinin 266ca48
Merge branch 'main' into rules-with-gap-status
nkhristinin e01520d
Update x-pack/solutions/security/plugins/security_solution/public/det…
nkhristinin 4d67f8b
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 9d8cdca
renamame function
nkhristinin cdce191
Move utils to to common folder
nkhristinin 099b792
Change docs description
nkhristinin 82062ee
Merge branch 'rules-with-gap-status' of github.com:nkhristinin/kibana…
nkhristinin d6ec8ed
Changes from yarn openapi:bundle
kibanamachine 7747db4
Changes from make api-docs
kibanamachine 15167f5
avoid unecessary filter change
nkhristinin 651f2b9
Merge branch 'main' into rules-with-gap-status
maximpn f091826
Merge branch 'main' into rules-with-gap-status
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It'd be nice to have comments describing the meaning of gapStatus and gapFillStatus with links to gap definition and extra details.