Fix canvas working in non-default spaces #24170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
WIP
Member
Author
|
@spalger what are your thoughts here? I added a |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
legrego
force-pushed
the
spaces/canvas
branch
from
4f039ed to
e0c6a94
Compare
Contributor
💚 Build Succeeded |
legrego
changed the title
Contributor
|
Simpler fix created in #24369, per this comment. This is no longer something we need for 6.5. We should definitely figure this out soon though. |
Member
Author
|
Closing for now, until we have time to revisit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23168
This PR allows canvas to work in spaces other than the default space by defining a
socketBasePathwhich is used to connect to Canvas's socket.io endpoint.The socket connection itself does not need to be space-aware. I tested this by creating workpads in several spaces, and they are correctly saved to the correct space every time.