fix: Failing test: X-Pack Accessibility Tests.x-pack/test/accessibiliy/apps/dashboard_panel_options·ts - Dashboard panel options a11y tests dashboard panel - clone panel #241259
Conversation
…ty/apps/dashboard_panel_options·ts - Dashboard panel options a11y tests dashboard panel - clone panel Closes: elastic#147667
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9766[✅] x-pack/platform/test/accessibility/apps/group1/config.ts: 2/2 tests passed. |
alexwizp
added
Project:Accessibility
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9772[✅] x-pack/platform/test/accessibility/apps/group1/config.ts: 25/25 tests passed. |
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
@elastic/kibana-presentation please review |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
| await testSubjects.click('euiFlyoutCloseButton'); | ||
| }); | ||
|
|
||
| it('dashboard panel - save to library', async () => { |
There was a problem hiding this comment.
Why is this test case removed?
There was a problem hiding this comment.
@nreese Most probably this is a bad test — I think the idea was to check a11y for dashboardPanelActions.saveToLibrary modal. In reality, this method performs a save operation and returns us to the UI that we’ve already tested in one of the previous tests. It seems redundant to me.
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
…y/apps/dashboard_panel_options·ts - Dashboard panel options a11y tests dashboard panel - clone panel (elastic#241259) Closes: elastic#147667 **Depends on** elastic/eui#9166 Flaky tests have passed ✅
…y/apps/dashboard_panel_options·ts - Dashboard panel options a11y tests dashboard panel - clone panel (elastic#241259) Closes: elastic#147667 **Depends on** elastic/eui#9166 Flaky tests have passed ✅
4 participants
Closes: #147667
Depends on
elastic/eui#9166
Flaky tests have passed ✅