Skip to content

[8.19] [Security Solution][Detection Engine] Fix threshold rule logic with no group by fields defined (#241022) #241122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Oct 29, 2025
Merged

[8.19] [Security Solution][Detection Engine] Fix threshold rule logic with no group by fields defined (#241022) #241122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...urity_solution/server/lib/detection_engine/rule_types/threshold/find_threshold_signals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,7 @@ export const findThresholdSignals = async ({
searchAfterResults.searchErrors.push(...searchErrors);
loggedRequests.push(...(thresholdLoggedRequests ?? []));

if (isEmpty(searchErrors)) {
searchAfterResults.searchErrors.push(...searchErrors);
} else if (searchResult.aggregations != null) {
if (searchResult.aggregations != null) {
const docCount = searchResult.hits.total.value;
if (
docCount >= threshold.value &&
Expand Down
13 changes: 13 additions & 0 deletions .../detection_engine/rule_execution_logic/threshold/trial_license_complete_tier/threshold.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,19 @@ export default ({ getService }: FtrProviderContext) => {
expect(logs[0].warnings).not.toContain(getMaxAlertsWarning());
});

it('generates alerts from Threshold rules when threshold is met and no field is defined', async () => {
const rule: ThresholdRuleCreateProps = {
...getThresholdRuleForAlertTesting(['auditbeat-*']),
threshold: {
field: [],
value: 100,
},
};
const { previewId } = await previewRule({ supertest, rule });
const previewAlerts = await getPreviewAlerts({ es, previewId });
expect(previewAlerts.length).toEqual(1);
});

it('generates 2 alerts from Threshold rules when threshold is met', async () => {
const rule: ThresholdRuleCreateProps = {
...getThresholdRuleForAlertTesting(['auditbeat-*']),
Expand Down