[One Workflow] fix: spaces in internal actions#241066
Merged
shahargl merged 3 commits intoelastic:mainfrom Oct 29, 2025
Merged
Conversation
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
cc @shahargl |
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Oct 29, 2025
## Summary
Fixes internal Kibana actions not respecting space context when executed
through workflows.
## Problem
Actions were executing in the default space regardless of which space
the workflow was running in, breaking space isolation.
## Solution
- Pass `spaceId` from workflow context to `buildKibanaRequestFromAction`
- Apply `/s/{spaceId}` prefix to API paths for non-default spaces
- Maintain correct behavior for default space (no prefix required)
## Impact
All 454+ Kibana internal actions now correctly execute in their intended
space context.
Closes elastic/security-team#14425
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Oct 30, 2025
## Summary
Fixes internal Kibana actions not respecting space context when executed
through workflows.
## Problem
Actions were executing in the default space regardless of which space
the workflow was running in, breaking space isolation.
## Solution
- Pass `spaceId` from workflow context to `buildKibanaRequestFromAction`
- Apply `/s/{spaceId}` prefix to API paths for non-default spaces
- Maintain correct behavior for default space (no prefix required)
## Impact
All 454+ Kibana internal actions now correctly execute in their intended
space context.
Closes elastic/security-team#14425
ana-davydova
pushed a commit
to ana-davydova/kibana
that referenced
this pull request
Nov 3, 2025
## Summary
Fixes internal Kibana actions not respecting space context when executed
through workflows.
## Problem
Actions were executing in the default space regardless of which space
the workflow was running in, breaking space isolation.
## Solution
- Pass `spaceId` from workflow context to `buildKibanaRequestFromAction`
- Apply `/s/{spaceId}` prefix to API paths for non-default spaces
- Maintain correct behavior for default space (no prefix required)
## Impact
All 454+ Kibana internal actions now correctly execute in their intended
space context.
Closes elastic/security-team#14425
albertoblaz
pushed a commit
to albertoblaz/kibana
that referenced
this pull request
Nov 4, 2025
## Summary
Fixes internal Kibana actions not respecting space context when executed
through workflows.
## Problem
Actions were executing in the default space regardless of which space
the workflow was running in, breaking space isolation.
## Solution
- Pass `spaceId` from workflow context to `buildKibanaRequestFromAction`
- Apply `/s/{spaceId}` prefix to API paths for non-default spaces
- Maintain correct behavior for default space (no prefix required)
## Impact
All 454+ Kibana internal actions now correctly execute in their intended
space context.
Closes elastic/security-team#14425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes internal Kibana actions not respecting space context when executed through workflows.
Problem
Actions were executing in the default space regardless of which space the workflow was running in, breaking space isolation.
Solution
spaceIdfrom workflow context tobuildKibanaRequestFromAction/s/{spaceId}prefix to API paths for non-default spacesImpact
All 454+ Kibana internal actions now correctly execute in their intended space context.
Closes https://github.com/elastic/security-team/issues/14425