Skip to content

[9.2] [Markdown] Fix layout issues for markdown embeddables in small panels (#240806) #240993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Oct 28, 2025
Merged

[9.2] [Markdown] Fix layout issues for markdown embeddables in small panels (#240806) #240993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/platform/plugins/shared/dashboard_markdown/public/components/markdown_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import type { PublishingSubject } from '@kbn/presentation-publishing';
import { useStateFromPublishingSubject } from '@kbn/presentation-publishing';
import React, { useLayoutEffect, useRef } from 'react';
import { useMemoCss } from '@kbn/css-utils/public/use_memo_css';
import { FOOTER_HELP_TEXT, MarkdownFooter } from './markdown_footer';
import { SHORT_CONTAINER_QUERY, FOOTER_HELP_TEXT, MarkdownFooter } from './markdown_footer';
import { MarkdownRenderer } from './markdown_renderer';

interface EuiMarkdownEditorRef {
Expand All @@ -24,6 +24,11 @@ interface EuiMarkdownEditorRef {
}

const componentStyles = {
rootContainer: css({
display: 'flex',
width: '100%',
containerType: 'size',
}),
container: css({
width: '100%',
}),
Expand All @@ -43,6 +48,13 @@ const componentStyles = {
textarea: {
minBlockSize: 'initial',
},
[SHORT_CONTAINER_QUERY]: {
blockSize: `100%`,
// TODO: Do not use data-test-subj to style - should be fixed in EUI
'[data-test-subj="euiMarkdownEditorToolbar"]': {
display: 'none',
},
},
}),
};

Expand Down Expand Up @@ -82,7 +94,7 @@ export const MarkdownEditor = ({
const isSaveable = Boolean(value === '' || value !== content);

return (
<>
<div css={styles.rootContainer}>
<div
css={[styles.container, isPreview && styles.componentInvisible]}
onKeyDown={(e) => {
Expand Down Expand Up @@ -117,7 +129,7 @@ export const MarkdownEditor = ({
cancelButtonRef={cancelButtonRef}
isSaveable={isSaveable}
/>
</>
</div>
);
};

Expand Down
21 changes: 17 additions & 4 deletions src/platform/plugins/shared/dashboard_markdown/public/components/markdown_footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ import { i18n } from '@kbn/i18n';

export const FOOTER_HELP_TEXT = htmlIdGenerator()('markdownEditorFooterHelp');

// Container query for when the height is too short and we need to switch to a more compact layout
export const SHORT_CONTAINER_QUERY = `@container (max-height: 119px)`;

const footerStyles = {
footer: ({ euiTheme }: UseEuiTheme) =>
css({
padding: euiTheme.size.s,
borderRadius: `0 0 ${euiTheme.size.s} ${euiTheme.size.s}`,
width: '100%',
borderTop: `1px solid ${euiTheme.colors.borderBasePlain}`,
Expand All @@ -40,10 +42,21 @@ const footerStyles = {
opacity: 0.9,
inset: 0,
},
[SHORT_CONTAINER_QUERY]: {
borderTop: 'none',
right: 0,
width: 'auto',
zIndex: 1,
'&::before': {
background: 'none',
},
},
}),
buttonsContainer: ({ euiTheme }: UseEuiTheme) =>
css({
margin: euiTheme.size.s,
position: 'relative',
}),
buttonsContainer: css({
position: 'relative',
}),
previewFooter: ({ euiTheme }: UseEuiTheme) =>
css({
opacity: 0,
Expand Down