Discover translations#24079
Merged
maryia-lapata merged 24 commits intoelastic:masterfrom Nov 20, 2018
Merged
Conversation
Contributor
💔 Build Failed |
pavel06081991
requested review from
maryia-lapata
and removed request for
pavel06081991
maryia-lapata
suggested changes
Oct 21, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
Pease fix the comment.
https://github.com/elastic/kibana/pull/24079/files#diff-3acdfbed044ff30a7ee38e913d157566R21
Here hit and hits should be translated as well.
| under the “Scripted fields” tab. | ||
| <FormattedMessage | ||
| id="kbn.discover.fetchError.howToAddressErrorDescription" | ||
| defaultMessage="You can address this error by editing the ‘{fetchErrorScript}’ field |
Contributor
There was a problem hiding this comment.
Please move ‘ and ’ to fetchErrorScript value and align default message:
defaultMessage="You can address this error by editing the {fetchErrorScript} field in {managementLink},
under the “Scripted fields” tab."
| css-truncate-expandable="true" | ||
| class="dscFieldDetails__value" | ||
| aria-label="Value: {{:: bucket.display === '' ? 'Empty string' : bucket.display }}" | ||
| aria-label="{{bucketAriaLabel}}" |
Contributor
There was a problem hiding this comment.
Please use bind once here.
| </label> | ||
| <label | ||
| for="discoverFieldChooserFilterAggregatable" | ||
| i18n-id="kbn.discover.fieldChooser.aggregatableLabel" |
Contributor
There was a problem hiding this comment.
kbn.discover.fieldChooser.aggregatableLabel => kbn.discover.fieldChooser.filter.aggregatableLabel
| </label> | ||
| <label | ||
| for="discoverFieldChooserFilterSearchable" | ||
| i18n-id="kbn.discover.fieldChooser.searchableLabel" |
Contributor
There was a problem hiding this comment.
kbn.discover.fieldChooser. => kbn.discover.fieldChooser.filter.
| </label> | ||
| <label | ||
| for="discoverFieldChooserFilterType" | ||
| i18n-id="kbn.discover.fieldChooser.typeLabel" |
Contributor
There was a problem hiding this comment.
kbn.discover.fieldChooser. => kbn.discover.fieldChooser.filter.
| <h3> | ||
| Address shard failures | ||
| <FormattedMessage | ||
| id="kbn.discover.noResults.addressShardFailures" |
Contributor
There was a problem hiding this comment.
.addressShardFailures -> .addressShardFailuresTitle
| defaultMessage="One or more of the indices you’re looking at contains a date field. Your query may | ||
| not match anything in the current time range, or there may not be any data at all in | ||
| the currently selected time range. You can try {timepickerLink} and changing the time range to one which contains data. | ||
| " |
Contributor
There was a problem hiding this comment.
Please move double quote to the previous line.
| import { FeatureCatalogueRegistryProvider, FeatureCatalogueCategory } from 'ui/registry/feature_catalogue'; | ||
|
|
||
| FeatureCatalogueRegistryProvider.register(() => { | ||
| FeatureCatalogueRegistryProvider.register((i18n) => { |
| if (status.remaining > 0) { | ||
| const inspectorRequest = inspectorAdapters.requests.start( | ||
| `Segment ${$scope.fetchStatus.complete}`, | ||
| i18n('kbn.discover.segmentFetchCompleteStatusTitle', { |
Contributor
There was a problem hiding this comment.
=> kbn.discover.inspectorRequest.segmentFetchCompleteStatusTitle
| }), | ||
| { | ||
| description: `This request queries Elasticsearch to fetch the data for the search.`, | ||
| description: i18n('kbn.discover.segmentFetchCompleteStatusDescription', { |
Contributor
There was a problem hiding this comment.
=> kbn.discover.inspectorRequest.segmentFetchCompleteStatusDescription
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
timroes
added
the
Team:Visualizations
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
maryia-lapata
suggested changes
Nov 5, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
Please look at my comments.
src/core_plugins/kibana/public/discover/components/fetch_error/fetch_error.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/components/fetch_error/fetch_error.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/discover/controllers/get_painless_error.ts
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
…na into feature/discover-translations
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Bargs
approved these changes
Nov 9, 2018
Contributor
Bargs
left a comment
Bargs
left a comment
There was a problem hiding this comment.
I can't judge the translation code itself since I'm not familiar with the best practices there but I pulled down the PR and poked at Discover for awhile and everything still seems to be working correctly. LGTM.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
…na into feature/discover-translations
Contributor
💚 Build Succeeded |
pavel06081991
pushed a commit
to pavel06081991/kibana
that referenced
this pull request
Nov 20, 2018
* translate discover plugin * update discover translation PR * Update fetch_error.js * Update unit tests * Fix eslint * use separate span tag for label * use separate tags for translated labels * resolve review comments * Update snapshot * fix issue with bucket aria-label * fix quotes * Update snapshot * fix quotes * update snapshots
pavel06081991
added a commit
that referenced
this pull request
Nov 21, 2018
sorenlouv
reviewed
Dec 4, 2018
| defaultMessage="You can address this error by editing the {fetchErrorScript} field | ||
| in {managementLink}, under the {scriptedFields} tab." | ||
| values={{ | ||
| fetchErrorScript: '‘' + fetchError.script + '’', |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation of Discover visualization component