Skip to content

[9.2] [scout] fix discover flaky test (#240068) #240153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 2 commits into from
Nov 4, 2025
Merged

[9.2] [scout] fix discover flaky test (#240068) #240153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d800de8
[scout] fix discover flaky test (#240068)
dmlemeshko Oct 22, 2025
4f54bf8
Merge branch '9.2' into backport/9.2/pr-240068
dmlemeshko Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/platform/packages/shared/kbn-scout/src/playwright/page_objects/fiter_bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,21 @@ export class FilterBar {
);
await this.page.click(`.euiFilterSelectItem[title="${options.field}"]`);
// set operator
await expect(this.page.testSubj.locator('filterOperatorList')).not.toHaveClass(
/euiComboBox-isDisabled/
);
await this.page.testSubj.typeWithDelay(
'filterOperatorList > comboBoxSearchInput',
options.operator
);
await this.page.click(`.euiFilterSelectItem[title="${options.operator}"]`);
// set value
await this.page.testSubj.locator('filterParams').locator('input').fill(options.value);
const filterParamsInput = this.page.locator('[data-test-subj="filterParams"] input');
await expect(filterParamsInput).not.toHaveAttribute('disabled');
// await this.page.waitForTimeout(100); // wait for input to be ready
await expect(filterParamsInput).toBeEditable();
await filterParamsInput.focus();
await filterParamsInput.pressSequentially(options.value, { delay: 100 });
// save filter
await this.page.testSubj.click('saveFilter');

Expand Down
8 changes: 7 additions & 1 deletion ...orm/plugins/private/discover_enhanced/test/scout/ui/parallel_tests/saved_searches.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ spaceTest.describe(
...filterFieldAndValue,
operator: 'is',
});
expect(
await pageObjects.filterBar.hasFilter({
...filterFieldAndValue,
enabled: true, // Filter is enabled by default
})
).toBe(true);
await page.testSubj.fill('queryInput', SEARCH_QUERY);
await page.testSubj.click('querySubmitButton');
await pageObjects.discover.waitForHistogramRendered();
Expand All @@ -100,7 +106,7 @@ spaceTest.describe(
expect(
await pageObjects.filterBar.hasFilter({
...filterFieldAndValue,
enabled: true, // Filter is enabled by default
enabled: true, // Filter is still enabled
})
).toBe(true);
await expect(page.testSubj.locator('queryInput')).toHaveText(SEARCH_QUERY);
Expand Down