[SLO] exclude stale SLOs from group by stats#240077
Merged
mgiota merged 3 commits intoelastic:mainfrom Nov 4, 2025
Merged
Conversation
github-actions
bot
added
the
author:obs-ux-management
mgiota
added
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Comment on lines
+36
to
+61
| function excludeStaleSummaryFilter( | ||
| settings: StoredSLOSettings, | ||
| kqlFilter: string, | ||
| hideStale?: boolean | ||
| ): estypes.QueryDslQueryContainer[] { | ||
| if (kqlFilter.includes('summaryUpdatedAt') || !settings.staleThresholdInHours || !hideStale) { | ||
| return []; | ||
| } | ||
| return [ | ||
| { | ||
| bool: { | ||
| should: [ | ||
| { term: { isTempDoc: true } }, | ||
| { | ||
| range: { | ||
| summaryUpdatedAt: { | ||
| gte: `now-${settings.staleThresholdInHours}h`, | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ]; | ||
| } | ||
|
|
mgiota
added
backport:version
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @mgiota |
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/19080850953 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2025
Fixes elastic#240075 Stale SLOs (SLOs not updated within the defined stale threshold under SLO > Settings) are hidden by default from the SLO overview list. However when user groups by instance id, the stale SLOs were not excluded from the group by stats shown in the accordion title. This PR excludes stale SLOs from the group by stats. **Before** <img width="600" height="681" alt="Screenshot 2025-10-22 at 14 30 32" src="https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9" /> **After** <img width="600" height="623" alt="Screenshot 2025-10-22 at 14 33 37" src="https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a" /> **Note** If user wants to see the stale SLOs, they can click on the `Stale stat` number and the stale SLOs will be displayed. (cherry picked from commit 82528fc)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2025
# Backport This will backport the following commits from `main` to `9.2`: - [[SLO] exclude stale SLOs from group by stats (#240077)](#240077) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Panagiota Mitsopoulou","email":"panagiota.mitsopoulou@elastic.co"},"sourceCommit":{"committedDate":"2025-11-04T19:43:40Z","message":"[SLO] exclude stale SLOs from group by stats (#240077)\n\nFixes https://github.com/elastic/kibana/issues/240075\n\nStale SLOs (SLOs not updated within the defined stale threshold under\nSLO > Settings) are hidden by default from the SLO overview list.\nHowever when user groups by instance id, the stale SLOs were not\nexcluded from the group by stats shown in the accordion title. This PR\nexcludes stale SLOs from the group by stats.\n\n**Before**\n\n<img width=\"600\" height=\"681\" alt=\"Screenshot 2025-10-22 at 14 30 32\"\nsrc=\"https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9\"\n/>\n\n**After**\n\n<img width=\"600\" height=\"623\" alt=\"Screenshot 2025-10-22 at 14 33 37\"\nsrc=\"https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a\"\n/>\n\n\n**Note**\nIf user wants to see the stale SLOs, they can click on the `Stale stat`\nnumber and the stale SLOs will be displayed.","sha":"82528fcd2f7f353bcdd248a1c11c34d40d6a9cf8","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:obs-ux-management","backport:version","v9.3.0","v8.19.7","v9.1.7","v9.2.1"],"title":"[SLO] exclude stale SLOs from group by stats","number":240077,"url":"https://github.com/elastic/kibana/pull/240077","mergeCommit":{"message":"[SLO] exclude stale SLOs from group by stats (#240077)\n\nFixes https://github.com/elastic/kibana/issues/240075\n\nStale SLOs (SLOs not updated within the defined stale threshold under\nSLO > Settings) are hidden by default from the SLO overview list.\nHowever when user groups by instance id, the stale SLOs were not\nexcluded from the group by stats shown in the accordion title. This PR\nexcludes stale SLOs from the group by stats.\n\n**Before**\n\n<img width=\"600\" height=\"681\" alt=\"Screenshot 2025-10-22 at 14 30 32\"\nsrc=\"https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9\"\n/>\n\n**After**\n\n<img width=\"600\" height=\"623\" alt=\"Screenshot 2025-10-22 at 14 33 37\"\nsrc=\"https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a\"\n/>\n\n\n**Note**\nIf user wants to see the stale SLOs, they can click on the `Stale stat`\nnumber and the stale SLOs will be displayed.","sha":"82528fcd2f7f353bcdd248a1c11c34d40d6a9cf8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240077","number":240077,"mergeCommit":{"message":"[SLO] exclude stale SLOs from group by stats (#240077)\n\nFixes https://github.com/elastic/kibana/issues/240075\n\nStale SLOs (SLOs not updated within the defined stale threshold under\nSLO > Settings) are hidden by default from the SLO overview list.\nHowever when user groups by instance id, the stale SLOs were not\nexcluded from the group by stats shown in the accordion title. This PR\nexcludes stale SLOs from the group by stats.\n\n**Before**\n\n<img width=\"600\" height=\"681\" alt=\"Screenshot 2025-10-22 at 14 30 32\"\nsrc=\"https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9\"\n/>\n\n**After**\n\n<img width=\"600\" height=\"623\" alt=\"Screenshot 2025-10-22 at 14 33 37\"\nsrc=\"https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a\"\n/>\n\n\n**Note**\nIf user wants to see the stale SLOs, they can click on the `Stale stat`\nnumber and the stale SLOs will be displayed.","sha":"82528fcd2f7f353bcdd248a1c11c34d40d6a9cf8"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Panagiota Mitsopoulou <panagiota.mitsopoulou@elastic.co>
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Nov 5, 2025
Fixes elastic#240075 Stale SLOs (SLOs not updated within the defined stale threshold under SLO > Settings) are hidden by default from the SLO overview list. However when user groups by instance id, the stale SLOs were not excluded from the group by stats shown in the accordion title. This PR excludes stale SLOs from the group by stats. **Before** <img width="600" height="681" alt="Screenshot 2025-10-22 at 14 30 32" src="https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9" /> **After** <img width="600" height="623" alt="Screenshot 2025-10-22 at 14 33 37" src="https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a" /> **Note** If user wants to see the stale SLOs, they can click on the `Stale stat` number and the stale SLOs will be displayed.
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Nov 5, 2025
Fixes elastic#240075 Stale SLOs (SLOs not updated within the defined stale threshold under SLO > Settings) are hidden by default from the SLO overview list. However when user groups by instance id, the stale SLOs were not excluded from the group by stats shown in the accordion title. This PR excludes stale SLOs from the group by stats. **Before** <img width="600" height="681" alt="Screenshot 2025-10-22 at 14 30 32" src="https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9" /> **After** <img width="600" height="623" alt="Screenshot 2025-10-22 at 14 33 37" src="https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a" /> **Note** If user wants to see the stale SLOs, they can click on the `Stale stat` number and the stale SLOs will be displayed.
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
Fixes elastic#240075 Stale SLOs (SLOs not updated within the defined stale threshold under SLO > Settings) are hidden by default from the SLO overview list. However when user groups by instance id, the stale SLOs were not excluded from the group by stats shown in the accordion title. This PR excludes stale SLOs from the group by stats. **Before** <img width="600" height="681" alt="Screenshot 2025-10-22 at 14 30 32" src="https://github.com/user-attachments/assets/fba3458e-bf05-49ec-a25a-4aa64ff973a9" /> **After** <img width="600" height="623" alt="Screenshot 2025-10-22 at 14 33 37" src="https://github.com/user-attachments/assets/34f7b070-ed3c-4662-83c3-84b77048544a" /> **Note** If user wants to see the stale SLOs, they can click on the `Stale stat` number and the stale SLOs will be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240075
Stale SLOs (SLOs not updated within the defined stale threshold under SLO > Settings) are hidden by default from the SLO overview list. However when user groups by instance id, the stale SLOs were not excluded from the group by stats shown in the accordion title. This PR excludes stale SLOs from the group by stats.
Before
After
Note
If user wants to see the stale SLOs, they can click on the
Stale statnumber and the stale SLOs will be displayed.