Skip to content

[8.19] [Security Solution] Remove D&R helpers duplicates (#235972)#240073

Merged
nikitaindik merged 1 commit intoelastic:8.19from
nikitaindik:backport/8.19/pr-235972
Oct 23, 2025
Merged

[8.19] [Security Solution] Remove D&R helpers duplicates (#235972)#240073
nikitaindik merged 1 commit intoelastic:8.19from
nikitaindik:backport/8.19/pr-235972

Conversation

@nikitaindik
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

**Partially addresses: elastic#234642
**Follow-up issue to extract into package:
elastic#240043

# Summary

This PR removes duplicated Detections & Response test utils directory
that was used by `cases_api_integrations` tests. The removed directory
was located at
`x-pack/solutions/security/test/common/utils/detections_response`.

# Changes
- Removed duplicated utils directory at
`x-pack/solutions/security/test/common/utils/detections_response`
- Updated util imports in `cases_api_integrations` directory to import
from
`x-pack/solutions/security/test/security_solution_api_integration/config/services/detections_response`
instead of the removed directory
- Added a `tsconfig.json` for the utils directory to make it importable
from both `security_solution_api_integration` and
`cases_api_integrations`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 9f98970)

# Conflicts:
#	x-pack/solutions/security/test/common/utils/detections_response/index.ts
#	x-pack/solutions/security/test/common/utils/detections_response/rules/delete_all_rules.ts
#	x-pack/solutions/security/test/common/utils/detections_response/rules/get_gaps_by_rule_id.ts
@nikitaindik nikitaindik added the backport This PR is a backport of another PR label Oct 22, 2025
@nikitaindik nikitaindik enabled auto-merge (squash) October 22, 2025 11:38
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.7MB 3.7MB -129.0B

@nikitaindik nikitaindik merged commit a52b1f9 into elastic:8.19 Oct 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants