[scout] fix discover flaky test #240068
[scout] fix discover flaky test #240068
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9607[❌] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 6/20 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9609[❌] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 9/20 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9611[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 20/20 tests passed. |
dmlemeshko
changed the title
…shko/kibana into scout/fix-flaky-saved-search-test
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9614[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 20/20 tests passed. |
dmlemeshko
added
release_note:skip
| await expect(this.page.testSubj.locator('filterOperatorList')).not.toHaveClass( | ||
| /euiComboBox-isDisabled/ | ||
| ); |
There was a problem hiding this comment.
waiting for operator comboBox to be enabled
| await this.page.testSubj.locator('filterParams').locator('input').fill(options.value); | ||
| const filterParamsInput = this.page.locator('[data-test-subj="filterParams"] input'); | ||
| await expect(filterParamsInput).not.toHaveAttribute('disabled'); | ||
| // await this.page.waitForTimeout(100); // wait for input to be ready |
There was a problem hiding this comment.
is this line forgotten?
There was a problem hiding this comment.
this is for the future to save time on researching the fix. Let's keep it so that we quickly add it if more failures to come.
| await expect(filterParamsInput).not.toHaveAttribute('disabled'); | ||
| // await this.page.waitForTimeout(100); // wait for input to be ready |
There was a problem hiding this comment.
According flaky-test-runner waiting for input to "lose" disabled attr solve flakiness, but I'm keeping timeout for the future as an alternative.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9615[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 20/20 tests passed. |
| await expect(filterParamsInput).toBeEditable(); | ||
| await filterParamsInput.focus(); | ||
| await filterParamsInput.pressSequentially(options.value, { delay: 100 }); |
There was a problem hiding this comment.
Making typing more realistic and slower
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9617[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 25/25 tests passed. |
|
Starting backport for target branches: 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/18725161507 |
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
## Summary Fixing discover flaky test, caused by filter value input field not being properly populated. I believe it is also related to the recent EUI update and probably shadow changes in elastic/eui#9088 require us to wait before typing in input field. (cherry picked from commit 68841a2)
## Summary Fixing discover flaky test, caused by filter value input field not being properly populated. I believe it is also related to the recent EUI update and probably shadow changes in elastic/eui#9088 require us to wait before typing in input field. (cherry picked from commit 68841a2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
6 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
# Backport This will backport the following commits from `main` to `9.1`: - [[scout] fix discover flaky test (#240068)](#240068) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-22T17:52:31Z","message":"[scout] fix discover flaky test (#240068)\n\n## Summary\n\nFixing discover flaky test, caused by filter value input field not being\nproperly populated. I believe it is also related to the recent EUI\nupdate and probably shadow changes in\nhttps://github.com/elastic/eui/pull/9088 require us to wait before\ntyping in input field.","sha":"68841a2793084c7a4a5bf36741e1572d09ccb1b1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0","v9.1.6"],"title":"[scout] fix discover flaky test","number":240068,"url":"https://github.com/elastic/kibana/pull/240068","mergeCommit":{"message":"[scout] fix discover flaky test (#240068)\n\n## Summary\n\nFixing discover flaky test, caused by filter value input field not being\nproperly populated. I believe it is also related to the recent EUI\nupdate and probably shadow changes in\nhttps://github.com/elastic/eui/pull/9088 require us to wait before\ntyping in input field.","sha":"68841a2793084c7a4a5bf36741e1572d09ccb1b1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240068","number":240068,"mergeCommit":{"message":"[scout] fix discover flaky test (#240068)\n\n## Summary\n\nFixing discover flaky test, caused by filter value input field not being\nproperly populated. I believe it is also related to the recent EUI\nupdate and probably shadow changes in\nhttps://github.com/elastic/eui/pull/9088 require us to wait before\ntyping in input field.","sha":"68841a2793084c7a4a5bf36741e1572d09ccb1b1"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <[email protected]>
# Backport This will backport the following commits from `main` to `9.2`: - [[scout] fix discover flaky test (#240068)](#240068) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-22T17:52:31Z","message":"[scout] fix discover flaky test (#240068)\n\n## Summary\n\nFixing discover flaky test, caused by filter value input field not being\nproperly populated. I believe it is also related to the recent EUI\nupdate and probably shadow changes in\nhttps://github.com/elastic/eui/pull/9088 require us to wait before\ntyping in input field.","sha":"68841a2793084c7a4a5bf36741e1572d09ccb1b1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0","v9.1.6"],"title":"[scout] fix discover flaky test","number":240068,"url":"https://github.com/elastic/kibana/pull/240068","mergeCommit":{"message":"[scout] fix discover flaky test (#240068)\n\n## Summary\n\nFixing discover flaky test, caused by filter value input field not being\nproperly populated. I believe it is also related to the recent EUI\nupdate and probably shadow changes in\nhttps://github.com/elastic/eui/pull/9088 require us to wait before\ntyping in input field.","sha":"68841a2793084c7a4a5bf36741e1572d09ccb1b1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240068","number":240068,"mergeCommit":{"message":"[scout] fix discover flaky test (#240068)\n\n## Summary\n\nFixing discover flaky test, caused by filter value input field not being\nproperly populated. I believe it is also related to the recent EUI\nupdate and probably shadow changes in\nhttps://github.com/elastic/eui/pull/9088 require us to wait before\ntyping in input field.","sha":"68841a2793084c7a4a5bf36741e1572d09ccb1b1"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <[email protected]>
kibanamachine
added
v9.2.1
and removed
backport missing
5 participants
Summary
Fixing discover flaky test, caused by filter value input field not being properly populated. I believe it is also related to the recent EUI update and probably shadow changes in elastic/eui#9088 require us to wait before typing in input field.