[Tools] Fix pug regular expression#24006
Merged
LeanidShutau merged 3 commits intoelastic:masterfrom Oct 17, 2018
Merged
Conversation
LeanidShutau
added
Team:Core
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
maryia-lapata
approved these changes
Oct 16, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM.
I checked with an example: .kibanaWelcomeText(data-error-message=i18n('common.ui.welcomeErrorMessage', { defaultMessage: 'Kibana did not load properly. Check the server output for more information.' }))
The message is extracted by the tool.
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
LeanidShutau
added a commit
to LeanidShutau/kibana
that referenced
this pull request
Oct 17, 2018
* [Tools] Fix pug regular expression * Add one more test
LeanidShutau
added a commit
that referenced
this pull request
Oct 17, 2018
Contributor
Author
|
6.x/6.5: b2ba7c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual
i18n_checkparses only interpolation expressions in Pug:#{i18n(...)}.Expected
i18nfunction can be called without#{...}interpolation, e.g.h2= i18n(...)i18n_checktool should parse all possiblei18n(...)use cases.