Skip to content

[Contextual Security] Misconfiguration Findings Page Accesibility Update #240005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
animehart merged 7 commits into from
Oct 29, 2025
Merged

[Contextual Security] Misconfiguration Findings Page Accesibility Update #240005

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb9ff9e
addressing 208266
animehart Oct 22, 2025
70f68be
addressing 208127
animehart Oct 22, 2025
9677494
addressing 208125
animehart Oct 22, 2025
6e00cb6
update 208125
animehart Oct 22, 2025
e1ca4e8
reverting back changes made to take_action, will do this on separate PR
animehart Oct 27, 2025
d19731c
Merge branch 'main' into accesibility-misconfiguration-1
animehart Oct 27, 2025
447cd15
Merge branch 'main' into accesibility-misconfiguration-1
animehart Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion ...loud_security_posture/public/components/cloud_security_data_table/additional_controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { EuiButtonEmpty, EuiFlexItem } from '@elastic/eui';
import { type DataView } from '@kbn/data-views-plugin/common';
import { FormattedMessage } from '@kbn/i18n-react';
import { getAbbreviatedNumber } from '@kbn/cloud-security-posture-common';
import { i18n } from '@kbn/i18n';
import { FieldsSelectorModal, useFieldsModal } from './fields_selector';
import { useStyles } from './use_styles';
import { CSP_FIELDS_SELECTOR_OPEN_BUTTON } from '../test_subjects';
Expand Down Expand Up @@ -59,7 +60,18 @@ export const AdditionalControls = ({
/>
)}
<EuiFlexItem grow={0}>
<span className="cspDataTableTotal">{`${getAbbreviatedNumber(total)} ${title}`}</span>
<div
className="cspDataTableTotal"
role="status"
aria-live="polite"
aria-label={i18n.translate('xpack.csp.dataTable.totalFindings', {
defaultMessage: 'Total findings: {total} {title}',
values: { total: getAbbreviatedNumber(total), title },
})}
tabIndex={0}
>
{`${getAbbreviatedNumber(total)} ${title}`}
</div>
</EuiFlexItem>
<EuiFlexItem grow={0}>
<EuiButtonEmpty
Expand All @@ -68,6 +80,12 @@ export const AdditionalControls = ({
size="xs"
color="text"
data-test-subj={CSP_FIELDS_SELECTOR_OPEN_BUTTON}
aria-label={i18n.translate('xpack.csp.dataTable.fieldsButtonAriaLabel', {
defaultMessage: 'Open fields selector to customize table columns',
})}
title={i18n.translate('xpack.csp.dataTable.fieldsButtonTooltip', {
defaultMessage: 'Select which fields to display in the table',
})}
>
<FormattedMessage id="xpack.csp.dataTable.fieldsButton" defaultMessage="Fields" />
</EuiButtonEmpty>
Expand Down