Skip to content

Translate global navigation bar component #23993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2018
Merged

Translate global navigation bar component #23993

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c7f904
Translate global navigation bar component
tibmt Oct 15, 2018
8bd6dc1
Update global_nav.js
tibmt Oct 18, 2018
67fae8f
Merge branch 'master' into feature/translations/navBar
tibmt Oct 23, 2018
8acd134
Merge branch 'master' into feature/translations/navBar
tibmt Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/ui/public/chrome/directives/global_nav/global_nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { uiModules } from '../../../modules';

const module = uiModules.get('kibana');

module.directive('globalNav', (globalNavState, chrome) => {
module.directive('globalNav', (globalNavState, chrome, i18n) => {
return {
restrict: 'E',
replace: true,
Expand All @@ -46,8 +46,12 @@ module.directive('globalNav', (globalNavState, chrome) => {
scope.isGlobalNavOpen = isOpen;
scope.globalNavToggleButton = {
classes: isOpen ? 'global-nav-link--close' : undefined,
title: isOpen ? 'Collapse' : 'Expand',
tooltipContent: isOpen ? 'Collapse side bar' : 'Expand side bar',
title: isOpen ?
i18n('common.ui.chrome.globalNav.navToggleButtonCollapseTitle', { defaultMessage: 'Collapse' })
: i18n('common.ui.chrome.globalNav.navToggleButtonExpandTitle', { defaultMessage: 'Expand' }),
tooltipContent: isOpen ?
i18n('common.ui.chrome.globalNav.navToggleButtonCollapseTooltip', { defaultMessage: 'Collapse side bar' })
: i18n('common.ui.chrome.globalNav.navToggleButtonExpandTooltip', { defaultMessage: 'Expand side bar' }),
};

// Notify visualizations, e.g. the dashboard, that they should re-render.
Expand Down