Skip to content

Conversation

@tobio
Copy link
Member

@tobio tobio commented Oct 21, 2025

Summary

From the OpenAPI specification for discriminator properties:

This property SHOULD be required in the payload schema, as the behavior when the property is absent is undefined

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@tobio tobio self-assigned this Oct 21, 2025
@tobio tobio added the release_note:skip Skip the PR/issue when compiling release notes label Oct 21, 2025
@tobio tobio requested a review from a team as a code owner October 21, 2025 11:12
@tobio tobio added the backport:all-open Backport to all branches that could still receive a release label Oct 21, 2025
@tobio tobio requested review from joeypoon and pzl October 21, 2025 11:12
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Apologies for missing this when I initially made these changes

@tobio tobio enabled auto-merge (squash) October 23, 2025 21:16
@tobio tobio merged commit 46e5c69 into elastic:main Oct 23, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/18762451057

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @tobio

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Fleet] Remove agent policies revision bump after updating settings (#239977)
9.1 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.1:
- [Fleet] Remove agent policies revision bump after updating settings (#239977)
9.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 239898

Questions ?

Please refer to the Backport tool documentation

@tobio tobio added backport:skip This PR does not require backporting and removed backport:all-open Backport to all branches that could still receive a release labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants