Skip to content

[Ingest Pipelines] Fix filter button focus behavior in pipelines table#239692

Merged
damian-polewski merged 2 commits intoelastic:mainfrom
damian-polewski:ingest_pipelines/pipelines_table_fix_filter_button_focus
Oct 21, 2025
Merged

[Ingest Pipelines] Fix filter button focus behavior in pipelines table#239692
damian-polewski merged 2 commits intoelastic:mainfrom
damian-polewski:ingest_pipelines/pipelines_table_fix_filter_button_focus

Conversation

@damian-polewski
Copy link
Copy Markdown
Contributor

@damian-polewski damian-polewski commented Oct 20, 2025 •
edited by kibanamachine
Loading

Summary

Closes #217801

This PR fixes an issue with keyboard navigation focus for filter button in pipelines table.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@damian-polewski damian-polewski self-assigned this Oct 20, 2025
@damian-polewski damian-polewski requested a review from a team as a code owner October 20, 2025 08:55
@damian-polewski damian-polewski added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management backport:all-open Backport to all branches that could still receive a release labels Oct 20, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 20, 2025

Pinging @elastic/kibana-management (Team:Kibana Management)

@damian-polewski damian-polewski marked this pull request as draft October 20, 2025 10:53
@damian-polewski damian-polewski changed the title fix: filter button focus in pipelines table [Ingest Pipelines] Fix filter button focus behavior in pipelines table Oct 20, 2025
@damian-polewski damian-polewski marked this pull request as ready for review October 20, 2025 13:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 20, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 346.0KB 346.1KB +108.0B

History

cc @damian-polewski

sabarasaba
sabarasaba approved these changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, tested locally 🚀

@damian-polewski damian-polewski merged commit c9abe01 into elastic:main Oct 21, 2025
13 checks passed
@damian-polewski damian-polewski deleted the ingest_pipelines/pipelines_table_fix_filter_button_focus branch October 21, 2025 12:52
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 21, 2025

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/18684433114

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2025
@damian-polewski
[Ingest Pipelines] Fix filter button focus behavior in pipelines table (
5ecfc3e 
elastic#239692)

## Summary

Closes elastic#217801

This PR fixes an issue with keyboard navigation focus for filter button
in pipelines table.

(cherry picked from commit c9abe01)
@kibanamachine kibanamachine mentioned this pull request Oct 21, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 21, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.1 Backport failed because of merge conflicts
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 239692

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 21, 2025
@kibanamachine @damian-polewski
[9.2] [Ingest Pipelines] Fix filter button focus behavior in pipeline…
587602a 
…s table (#239692) (#239912)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[Ingest Pipelines] Fix filter button focus behavior in pipelines
table (#239692)](#239692)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Damian
Polewski","email":"125268832+damian-polewski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-21T12:51:54Z","message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","Feature:Ingest Node
Pipelines","backport:all-open","v9.3.0"],"title":"[Ingest Pipelines] Fix
filter button focus behavior in pipelines
table","number":239692,"url":"https://github.com/elastic/kibana/pull/239692","mergeCommit":{"message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239692","number":239692,"mergeCommit":{"message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518"}}]}]
BACKPORT-->

Co-authored-by: Damian Polewski <125268832+damian-polewski@users.noreply.github.com>
This was referenced Oct 22, 2025
Merged
Merged
@damian-polewski
Copy link
Copy Markdown
Contributor Author

damian-polewski commented Oct 22, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

damian-polewski added a commit to damian-polewski/kibana that referenced this pull request Oct 22, 2025
@damian-polewski
[Ingest Pipelines] Fix filter button focus behavior in pipelines table (
d47717a 
elastic#239692)

## Summary

Closes elastic#217801

This PR fixes an issue with keyboard navigation focus for filter button
in pipelines table.

(cherry picked from commit c9abe01)

# Conflicts:
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/table.tsx
damian-polewski added a commit to damian-polewski/kibana that referenced this pull request Oct 22, 2025
@damian-polewski
[Ingest Pipelines] Fix filter button focus behavior in pipelines table (
46cb38e 
elastic#239692)

## Summary

Closes elastic#217801

This PR fixes an issue with keyboard navigation focus for filter button
in pipelines table.

(cherry picked from commit c9abe01)

# Conflicts:
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/sections/pipelines_list/table.tsx
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2025
Merged
damian-polewski added a commit that referenced this pull request Oct 22, 2025
@damian-polewski
[8.19] [Ingest Pipelines] Fix filter button focus behavior in pipelin…
9ac180a 
…es table (#239692) (#240027)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Ingest Pipelines] Fix filter button focus behavior in pipelines
table (#239692)](#239692)

<!--- Backport version: 10.1.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Damian
Polewski","email":"125268832+damian-polewski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-21T12:51:54Z","message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","Feature:Ingest Node
Pipelines","backport:all-open","v9.2.0","v9.3.0"],"title":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines
table","number":239692,"url":"https://github.com/elastic/kibana/pull/239692","mergeCommit":{"message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/239912","number":239912,"state":"MERGED","mergeCommit":{"sha":"587602a73f8734f43cc5c74b2a3d6cb212a39b91","message":"[9.2]
[Ingest Pipelines] Fix filter button focus behavior in pipelines table
(#239692) (#239912)\n\n# Backport\n\nThis will backport the following
commits from `main` to `9.2`:\n- [[Ingest Pipelines] Fix filter button
focus behavior in pipelines\ntable
(#239692)](https://github.com/elastic/kibana/pull/239692)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Damian Polewski
<125268832+damian-polewski@users.noreply.github.com>"}},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239692","number":239692,"mergeCommit":{"message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518"}}]}]
BACKPORT-->
damian-polewski added a commit that referenced this pull request Oct 23, 2025
@damian-polewski @elasticmachine
[9.1] [Ingest Pipelines] Fix filter button focus behavior in pipeline…
fe86285 
…s table (#239692) (#240026)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Ingest Pipelines] Fix filter button focus behavior in pipelines
table (#239692)](#239692)

<!--- Backport version: 10.1.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Damian
Polewski","email":"125268832+damian-polewski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-21T12:51:54Z","message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","Feature:Ingest Node
Pipelines","backport:all-open","v9.2.0","v9.3.0"],"title":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines
table","number":239692,"url":"https://github.com/elastic/kibana/pull/239692","mergeCommit":{"message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/239912","number":239912,"state":"MERGED","mergeCommit":{"sha":"587602a73f8734f43cc5c74b2a3d6cb212a39b91","message":"[9.2]
[Ingest Pipelines] Fix filter button focus behavior in pipelines table
(#239692) (#239912)\n\n# Backport\n\nThis will backport the following
commits from `main` to `9.2`:\n- [[Ingest Pipelines] Fix filter button
focus behavior in pipelines\ntable
(#239692)](https://github.com/elastic/kibana/pull/239692)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Damian Polewski
<125268832+damian-polewski@users.noreply.github.com>"}},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239692","number":239692,"mergeCommit":{"message":"[Ingest
Pipelines] Fix filter button focus behavior in pipelines table
(#239692)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217801\n\nThis PR fixes an
issue with keyboard navigation focus for filter button\nin pipelines
table.","sha":"c9abe01bc243bcd131c81f91ab41fbf363519518"}}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Oct 27, 2025
@damian-polewski @NicholasPeretti
[Ingest Pipelines] Fix filter button focus behavior in pipelines table (
8a54110 
elastic#239692)

## Summary

Closes elastic#217801

This PR fixes an issue with keyboard navigation focus for filter button
in pipelines table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees

@damian-polewski damian-polewski

Labels

backport:all-open Backport to all branches that could still receive a release Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.19.7 v9.1.7 v9.2.1 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Platform:StackManagement:Ingest pipelines page]Incorrect navigation

5 participants

@damian-polewski @elasticmachine @kibanamachine @sabarasaba @mistic