chore(NA): upgrade typescript into v5.9.3

package.json

@@ -82,7 +82,8 @@
     "**/@langchain/core": "^0.3.78",
     "**/@langchain/google-common": "^0.2.18",
     "**/@types/node": "22.15.3",
-    "**/@typescript-eslint/utils": "8.16.0",
+    "**/@types/prop-types": "15.7.5",
+    "**/@typescript-eslint/utils": "8.46.3",
     "**/chokidar": "^3.5.3",
     "**/d3-scale/**/d3-color": "npm:@elastic/kibana-d3-color@2.0.1",
     "**/globule/minimatch": "^3.1.2",
@@ -91,10 +92,10 @@
     "**/langchain": "^0.3.35",
     "**/remark-parse/trim": "1.0.1",
     "**/sharp": "0.34.4",
-    "**/typescript": "5.4.5",
+    "**/typescript": "5.9.3",
     "**/util": "^0.12.5",
     "**/yauzl": "^3.2.0",
-    "**/zod": "^3.25.76",
+    "**/zod": "3.25.76",
     "@aws-sdk/client-bedrock-agent-runtime": "^3.879.0",
     "@aws-sdk/client-bedrock-runtime": "^3.879.0",
     "@aws-sdk/client-kendra": "3.879.0",
@@ -1877,9 +1878,9 @@
     "@types/yargs": "^15.0.0",
     "@types/yauzl": "^2.10.3",
     "@types/yazl": "^3.3.0",
-    "@typescript-eslint/eslint-plugin": "^8.16.0",
-    "@typescript-eslint/parser": "^8.16.0",
-    "@typescript-eslint/typescript-estree": "^8.16.0",
+    "@typescript-eslint/eslint-plugin": "^8.46.3",
+    "@typescript-eslint/parser": "^8.46.3",
+    "@typescript-eslint/typescript-estree": "^8.46.3",
     "@wojtekmaj/enzyme-adapter-react-17": "^0.6.7",
     "@yarnpkg/lockfile": "^1.1.0",
     "aggregate-error": "^3.1.0",
@@ -2049,7 +2050,7 @@
     "tree-kill": "^1.2.2",
     "ts-morph": "^15.1.0",
     "tsd": "^0.33.0",
-    "typescript": "5.4.5",
+    "typescript": "5.9.3",
     "val-loader": "^6.0.0",
     "vinyl-fs": "^4.0.0",
     "watchpack": "^1.6.0",

src/core/packages/overlays/browser-internal/src/banners/user_banner_service.test.ts

@@ -42,6 +42,7 @@ describe('OverlayBannersService', () => {
       i18n: i18nServiceMock.createStartContract(),
       theme: themeServiceMock.createStartContract(),
       uiSettings,
+      // @ts-expect-error upgrade typescript v5.9.3
       userProfile,
     });
   };

src/core/packages/saved-objects/api-server-internal/src/test_helpers/repository.test.common.ts

@@ -570,6 +570,7 @@ export const expectBulkGetResult = (
 ) => ({
   type,
   id,
+  // @ts-expect-error upgrade typescript v5.9.3
   namespaces: doc._source!.namespaces ?? [doc._source!.namespace] ?? ['default'],
   ...(doc._source!.originId && { originId: doc._source!.originId }),
   ...(doc._source!.updated_at && { updated_at: doc._source!.updated_at }),

src/core/server/integration_tests/elasticsearch/user_agent.test.ts

@@ -37,6 +37,7 @@ describe('ES Client - custom user-agent', () => {
 
   afterAll(async () => {
     try {
+      // @ts-expect-error upgrade typescript v5.9.3
       await kibanaServer?.shutdown();
     } catch (e) {
       // trap

src/platform/packages/private/kbn-import-resolver/src/import_resolver.ts

@@ -159,6 +159,14 @@ export class ImportResolver {
       return Path.resolve(REPO_ROOT, `node_modules/@typescript-eslint/parser/dist/index.js`);
     }
 
+    // zod migration from v3 to v4
+    if (req.startsWith('zod/v4')) {
+      return Path.resolve(REPO_ROOT, `node_modules/zod/v4/index.cjs`);
+    }
+    if (req.startsWith('zod') || req.startsWith('zod/v3')) {
+      return Path.resolve(REPO_ROOT, `node_modules/zod/v3/index.cjs`);
+    }
+
     // turn root-relative paths into relative paths
     if (
       req.startsWith('src/') ||

src/platform/packages/private/kbn-telemetry-tools/src/schema_ftr_validations/schema_to_config_schema.test.ts

@@ -155,7 +155,6 @@ describe(`assertTelemetryPayload`, () => {
         {
           root: {
             properties: {
-              // @ts-expect-error: TS doesn't allow pass_through with properties, but it may occur during the tests in runtime, so we want to validate this test case.
               im_only_passing_through_data: { type: 'pass_through', properties: {} },
             },
           },

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/search_alerts/search_alerts.ts

@@ -145,6 +145,7 @@ export const searchAlerts = ({
             total,
             querySnapshot: {
               request: response?.inspect?.dsl ?? [],
+              // @ts-expect-error upgrade typescript v5.9.3
               response: [JSON.stringify(rawResponse)] ?? [],
             },
             error: alertsError,

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/hooks/use_fetch_alerts_fields_query.test.tsx

@@ -71,7 +71,7 @@ describe('useFetchAlertsFieldsQuery', () => {
         initialProps: {
           ruleTypeIds: ['apm'],
           enabled: false,
-        },
+        } as { ruleTypeIds: string[]; enabled?: boolean },
       }
     );
 

src/platform/packages/shared/kbn-babel-register/transforms/index.js

@@ -12,6 +12,9 @@ const { dotTextTransform } = require('./dot_text');
 const { babelTransform } = require('./babel');
 
 module.exports = {
+  /**
+   * @type {Record<string, import('./types').Transform>}
+   */
   TRANSFORMS: {
     '.peggy': peggyTransform,
     '.text': dotTextTransform,

src/platform/packages/shared/kbn-coloring/src/shared_components/coloring/color_ranges/color_ranges.tsx

@@ -55,6 +55,7 @@ export function ColorRanges({
       gutterSize="s"
     >
       {colorRanges.map((colorRange, index) => (
+        // @ts-expect-error upgrade typescript v5.9.3
         <EuiFlexItem grow={false} key={`${colorRange.end ?? 0 + colorRange.start ?? 0}${index}`}>
           <ColorRangeItem
             colorRange={colorRange}

src/platform/packages/shared/kbn-dev-cli-runner/src/help.ts

@@ -128,7 +128,7 @@ export function getHelpForAllCommands({
       return [
         chalk.bold.whiteBright.bgBlack(` ${dedent(command.usage || '') || command.name} `),
         `  ${indent(dedent(command.description || 'Runs a dev task'), 2)}`,
-        ...([indent(options, 2)] || []),
+        ...[indent(options, 2)],
       ].join('\n');
     })
     .join('\n');

src/platform/packages/shared/kbn-dev-utils/src/streams.ts

@@ -10,10 +10,11 @@
 import { Transform } from 'stream';
 
 import type File from 'vinyl';
+import type { DirectoryFile } from 'vinyl';
 
 interface BufferedFile extends File {
   contents: Buffer;
-  isDirectory(): false;
+  isDirectory(): this is DirectoryFile;
 }
 
 /**

src/platform/packages/shared/kbn-discover-utils/src/utils/get_field_value.ts

@@ -14,5 +14,5 @@ export const getFieldValue = <TRecord extends DataTableRecord, TField extends st
   field: TField & keyof TRecord['flattened']
 ): TRecord['flattened'][TField] => {
   const value = record.flattened[field];
-  return Array.isArray(value) ? value[0] : value;
+  return Array.isArray(value) ? value[0] : (value as TRecord['flattened'][TField]);
 };

src/platform/packages/shared/kbn-es-mappings/src/type.test.ts

@@ -117,15 +117,19 @@ describe('Type checking with TypeScript compiler', () => {
           ],
         },
         Object {
-          "errorMessage": "Type 'Error & \\"The following keys are missing from the document fields: createdAt\\"' is not assignable to type 'MissingKeysError<\\"definedButNotInDocOne\\" | \\"definedButNotInDocTwo\\">'.",
+          "errorMessage": "Type 'Error & \\"The following keys are missing from the document fields: createdAt\\"' is not assignable to type 'MissingKeysError<\\"definedButNotInDocOne\\" | \\"definedButNotInDocTwo\\">'.
+        Type 'Error & \\"The following keys are missing from the document fields: createdAt\\"' is not assignable to type 'Error & \\"The following keys are missing from the document fields: definedButNotInDocTwo\\"'.
+          Type 'Error & \\"The following keys are missing from the document fields: createdAt\\"' is not assignable to type '\\"The following keys are missing from the document fields: definedButNotInDocTwo\\"'.",
           "lineNumber": 113,
           "tsErrorLine": Array [
             "Type Error Explanation: createdAt is in the definition, this checks that an error is not thrown for defined keys",
             "Error Line [113]: Object.assign(new Error(), 'The following keys are missing from the document fields: createdAt'),",
           ],
         },
         Object {
-          "errorMessage": "Type 'Error & \\"The following keys are missing from the document fields: Unknown Key\\"' is not assignable to type 'MissingKeysError<\\"definedButNotInDocOne\\" | \\"definedButNotInDocTwo\\">'.",
+          "errorMessage": "Type 'Error & \\"The following keys are missing from the document fields: Unknown Key\\"' is not assignable to type 'MissingKeysError<\\"definedButNotInDocOne\\" | \\"definedButNotInDocTwo\\">'.
+        Type 'Error & \\"The following keys are missing from the document fields: Unknown Key\\"' is not assignable to type 'Error & \\"The following keys are missing from the document fields: definedButNotInDocTwo\\"'.
+          Type 'Error & \\"The following keys are missing from the document fields: Unknown Key\\"' is not assignable to type '\\"The following keys are missing from the document fields: definedButNotInDocTwo\\"'.",
           "lineNumber": 115,
           "tsErrorLine": Array [
             "Type Error Explanation: Unknown Key is not in the definition, this checks that an error is thrown for the unknown key",

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/shared/resources_helpers.ts

@@ -61,6 +61,7 @@ export class QueryColumns {
     // Remove oldest entry if cache is full
     while (QueryColumns.cache.size >= QueryColumns.MAX_CACHE_SIZE) {
       const oldestKey = QueryColumns.cache.keys().next().value;
+      // @ts-expect-error upgrade typescript v5.9.3
       QueryColumns.cache.delete(oldestKey);
     }
 

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/config_builder.ts

@@ -204,6 +204,7 @@ export class LensConfigBuilder {
       throw new Error(`No API converter found for chart type: ${visType} as ${type}`);
     }
     const converter = this.apiConvertersByChart[type as keyof typeof this.apiConvertersByChart];
+    // @ts-expect-error upgrade typescript v5.9.3
     return {
       ...converter.fromLensStateToAPI(config),
       ...filtersAndQueryToApiFormat(config),

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/index.ts

@@ -7,11 +7,15 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import type { TypeOf } from '@kbn/config-schema';
+import type { Type } from '@kbn/config-schema';
 import { schema } from '@kbn/config-schema';
+import type { MetricState } from './charts/metric';
 import { metricStateSchema } from './charts/metric';
+import type { LegacyMetricState } from './charts/legacy_metric';
 import { legacyMetricStateSchema } from './charts/legacy_metric';
+import type { GaugeState } from './charts/gauge';
 import { gaugeStateSchema } from './charts/gauge';
+import type { TagcloudState } from './charts/tagcloud';
 import { tagcloudStateSchema } from './charts/tagcloud';
 import type {
   LensApiAllMetricOrFormulaOperations,
@@ -20,15 +24,25 @@ import type {
 import type { LensApiBucketOperations } from './bucket_ops';
 import { xyStateSchema } from './charts/xy';
 
-export const lensApiStateSchema = schema.oneOf([
+/**
+ * We need to break the type inference here to avoid exceeding the ts compiler serialization limit.
+ *
+ * This requires:
+ *  - Casting the schema as any
+ *  - Defining the `LensApiState` type from the schema types
+ *  - Exporting this value as `Type<LensApiState>`
+ */
+export const _lensApiStateSchema: any = schema.oneOf([
   metricStateSchema,
   legacyMetricStateSchema,
   xyStateSchema,
   gaugeStateSchema,
   tagcloudStateSchema,
 ]);
 
-export type LensApiState = TypeOf<typeof lensApiStateSchema>;
+export type LensApiState = MetricState | LegacyMetricState | GaugeState | TagcloudState;
+
+export const lensApiStateSchema: Type<LensApiState> = _lensApiStateSchema;
 
 export type { MetricState, metricStateSchemaNoESQL } from './charts/metric';
 export type { LegacyMetricState, legacyMetricStateSchemaNoESQL } from './charts/legacy_metric';

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/xy/xy.test.ts

@@ -123,6 +123,7 @@ describe('XY', () => {
     it.each(universalTypes)('should work for for a minimal %s', (type) => {
       validateAPIConverter(
         {
+          // @ts-expect-error upgrade typescript v5.9.3
           type: 'xy',
           title: `${type} Chart`,
           layers: [
@@ -142,6 +143,7 @@ describe('XY', () => {
     it.each(anyType)('should work for ES|QL mode for a minimal %s chart with breakdown', (type) => {
       validateAPIConverter(
         {
+          // @ts-expect-error upgrade typescript v5.9.3
           type: 'xy',
           title: `${type} Chart`,
           layers: [
@@ -169,6 +171,7 @@ describe('XY', () => {
       (type1, type2) => {
         validateAPIConverter(
           {
+            // @ts-expect-error upgrade typescript v5.9.3
             type: 'xy',
             title: `Mixed Chart`,
             layers: [

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/charts/xy.ts

@@ -28,6 +28,7 @@ type XYLensWithoutQueryAndFilters = Omit<XYLens, 'state'> & { state: XYLensState
 export function fromAPItoLensState(config: XYState): XYLensWithoutQueryAndFilters {
   // convert layers and produce references from them
   const { layers, usedDataviews } = buildDatasourceStates(
+    // @ts-expect-error upgrade typescript v5.9.3
     config,
     buildFormBasedXYLayer,
     getValueColumns

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/utils.ts

@@ -365,7 +365,9 @@ export const buildDatasourceStates = (
   > = {};
   // a few charts types support multiple layers
   const configLayers = 'layers' in config ? config.layers : [config];
+  // @ts-expect-error upgrade typescript v5.9.3
   for (let i = 0; i < configLayers.length; i++) {
+    // @ts-expect-error upgrade typescript v5.9.3
     const layer = configLayers[i];
     const layerId = `${layer.type ?? 'layer'}_${i}`;
     const dataset = 'dataset' in layer ? layer.dataset : mainDataset;

src/platform/packages/shared/kbn-management/settings/utilities/setting/normalize_settings.ts

@@ -85,7 +85,7 @@ const deriveValue = (type: SettingType, value: unknown): Value => {
     case 'boolean':
       return Boolean(value);
     case 'array':
-      return Array.isArray(value) ? value : [value];
+      return (Array.isArray(value) ? value : [value]) as Value;
     default:
       return value as string;
   }

src/platform/packages/shared/kbn-object-utils/src/calculate_object_diff.ts

@@ -75,7 +75,9 @@ export function calculateObjectDiff<TBase extends Obj, TCompare extends Obj>(
         removedMap[key] = [];
         updatedMap[key] = [];
         diffRecursive(
+          // @ts-expect-error upgrade typescript v5.9.3
           base[key] as Obj,
+          // @ts-expect-error upgrade typescript v5.9.3
           compare[key] as Obj,
           addedMap[key] as Obj,
           removedMap[key] as Obj,

src/platform/packages/shared/kbn-test/src/jest/resolver.js

@@ -85,7 +85,7 @@ module.exports = (request, options) => {
   }
 
   if (request.startsWith('zod/v4/')) {
-    return resolve.sync(`${request}/index.cjs`, {
+    return resolve.sync(`zod/v4/index.cjs`, {
       basedir: options.basedir,
       extensions: options.extensions,
     });

src/platform/packages/shared/kbn-unified-histogram/__mocks__/data_view.ts

@@ -110,7 +110,7 @@ export const buildDataViewMock = ({
     toMinimalSpec: () => ({}),
   } as unknown as DataView;
 
-  dataView.isTimeBased = () => !!timeFieldName;
+  dataView.isTimeBased = (() => !!timeFieldName) as DataView['isTimeBased'];
 
   return dataView;
 };

src/platform/packages/shared/kbn-workflows-ui/src/components/workflow_selector/workflow_selector.tsx

@@ -136,6 +136,7 @@ const WorkflowSelector: React.FC<WorkflowSelectorProps> = ({
     };
 
     const content = (
+      // @ts-expect-error upgrade typescript v5.9.3
       <>
         <>
           {getPrependContent(option)}

src/platform/packages/shared/presentation/presentation_containers/interfaces/presentation_container.ts

@@ -131,6 +131,7 @@ export const combineCompatibleChildrenApis = <ApiType extends unknown, Publishin
       const compatibleChildren: Array<Observable<PublishingSubjectType>> = [];
       for (const child of Object.values(children)) {
         if (isCompatible(child) && isObservable(child[observableKey]))
+          // @ts-expect-error upgrade typescript v5.9.3
           compatibleChildren.push(child[observableKey] as BehaviorSubject<PublishingSubjectType>);
       }
 

src/platform/packages/shared/response-ops/alerts-table/reducers/bulk_actions_reducer.test.tsx

@@ -166,6 +166,7 @@ describe('AlertsDataGrid bulk actions', () => {
     return (
       <QueryClientProvider client={queryClient} context={AlertsQueryContext}>
         <IntlProvider locale="en">
+          {/* @ts-expect-error upgrade typescript v5.9.3 */}
           <AlertsTableContextProvider value={renderContext}>
             <AlertsDataGrid {...({ ...props, renderContext } as BaseAlertsDataGridProps)} />
           </AlertsTableContextProvider>

src/platform/packages/shared/response-ops/rule_form/src/rule_actions/rule_actions_settings.tsx

@@ -172,6 +172,7 @@ export const RuleActionsSettings = (props: RuleActionsSettingsProps) => {
     ? getDurationUnitValue(action.frequency?.throttle)
     : 'h';
 
+  // @ts-expect-error upgrade typescript v5.9.3
   const [minimumActionThrottle = -1, minimumActionThrottleUnit] = [
     intervalNumber,
     intervalUnit,

src/platform/packages/shared/shared-ux/file/mocks/tsconfig.json

@@ -2,7 +2,6 @@
   "extends": "@kbn/tsconfig-base/tsconfig.json",
   "compilerOptions": {
     "outDir": "target/types",
-    "types": [ ]
   },
   "include": [
     "**/*.ts",

src/platform/plugins/private/kibana_overview/public/components/add_data/add_data.tsx

@@ -77,6 +77,7 @@ export const AddData: FC<Props> = ({ addBasePath, features }) => {
 
 AddData.propTypes = {
   addBasePath: PropTypes.func.isRequired,
+  // @ts-expect-error upgrade typescript v5.9.3
   features: PropTypes.arrayOf(
     PropTypes.shape({
       id: PropTypes.string.isRequired,

src/platform/plugins/private/kibana_overview/public/components/manage_data/manage_data.tsx

@@ -87,6 +87,7 @@ export const ManageData: FC<Props> = ({ addBasePath, features }) => {
 };
 
 ManageData.propTypes = {
+  // @ts-expect-error upgrade typescript v5.9.3
   features: PropTypes.arrayOf(
     PropTypes.shape({
       id: PropTypes.string.isRequired,

src/platform/plugins/private/vis_default_editor/public/components/controls/time_interval.tsx

@@ -140,6 +140,7 @@ function TimeIntervalParamEditor({
     ) : null;
 
   const helpText = (
+    // @ts-expect-error upgrade typescript v5.9.3
     <>
       {scaledHelpText}
       {get(editorConfig, 'interval.help') || selectOptionHelpText}

src/platform/plugins/private/vis_types/vega/public/vega_request_handler.ts

@@ -77,6 +77,7 @@ export function createVegaRequestHandler(
     let dataView: DataView;
     const firstFilterIndex = filters[0]?.meta.index;
     if (firstFilterIndex) {
+      // @ts-expect-error upgrade typescript v5.9.3
       dataView = await dataViews.get(firstFilterIndex).catch(() => undefined);
     }
 

src/platform/plugins/shared/charts/public/static/components/endzones.tsx

@@ -194,5 +194,6 @@ export const renderEndzoneTooltip =
       );
     }
 
+    // @ts-expect-error upgrade typescript v5.9.3
     return renderValue ? formattedValue : null;
   };