Skip to content

[8.18] [Lens][Table] Fix filtering on tables with formula columns (#239222) #239232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Oct 15, 2025
Merged

[8.18] [Lens][Table] Fix filtering on tables with formula columns (#239222) #239232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions x-pack/platform/plugins/shared/lens/common/expressions/datatable/datatable_fn.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,31 @@ describe('datatableFn', () => {
expect(resultColumnIds).toEqual(expectedColumnIds);
expect(resultColumnIds).toEqual(['bucket1', 'bucket2', 'bucket3', 'metric1', 'metric2']);
});

// This is needed for ghost formula columns, see https://github.com/elastic/kibana/issues/239170
it('should sort unknown columns in table by order of args.columns', async () => {
const table = buildTable();
const shuffledTable: Datatable = {
...table,
columns: shuffle([
...table.columns,
{ id: 'unknown', name: 'unknown', meta: { type: 'number' } },
]),
};
const args = buildArgs();
const result = await datatableFn(() => mockFormatFactory)(shuffledTable, args, context);

const resultColumnIds = result.value.data.columns.map((c) => c.id);
const expectedColumnIds = args.columns.map((c) => c.columnId).concat('unknown');

expect(resultColumnIds).toEqual(expectedColumnIds);
expect(resultColumnIds).toEqual([
'bucket1',
'bucket2',
'bucket3',
'metric1',
'metric2',
'unknown',
]);
});
});
2 changes: 1 addition & 1 deletion x-pack/platform/plugins/shared/lens/common/expressions/datatable/datatable_fn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const datatableFn =
): DatatableExpressionFunction['fn'] =>
async (table, args, context) => {
const columnSortMap = args.columns.reduce((acc, c, i) => acc.set(c.columnId, i), new Map());
const getColumnSort = (id: string) => columnSortMap.get(id) ?? -1;
const getColumnSort = (id: string) => columnSortMap.get(id) ?? Infinity;
const sortedTable: Datatable = {
...table,
columns: table.columns.slice().sort((a, b) => getColumnSort(a.id) - getColumnSort(b.id)),
Expand Down