Skip to content

Fix flaky reporting test that is failing due to a CSS animation #23907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisdavies merged 2 commits into from
Oct 10, 2018
Merged

Fix flaky reporting test that is failing due to a CSS animation #23907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02186da
Add a wait for the reporting flyout menu to animate
chrisdavies Oct 8, 2018
12cb391
Tweak the way we wait for menu animation in reporting tests
chrisdavies Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion x-pack/test/functional/page_objects/reporting_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@ export function ReportingPageProvider({ getService, getPageObjects }) {
}

async checkUsePrintLayout() {
await retry.try(() => testSubjects.click('usePrintLayout'));
// The print layout checkbox slides in as part of an animation, and tests can
// attempt to click it too quickly, leading to flaky tests. The 500ms wait allows
// the animation to complete before we attempt a click.
const menuAnimationDelay = 500;
await retry.tryForTime(menuAnimationDelay, () => testSubjects.click('usePrintLayout'));
}

async clickGenerateReportButton() {
Expand Down