[Automatic Migrations] Clear migration completion toast notification on navigation#239058
Conversation
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
I don't like that toast identity is only communicated after it has been raised but for raising we need the ID of the toast so that we can remove it later. But we cannot do anything about the core design of the toasts plugin. On the top of that managing toasts feels like an overkill for this. If we have manage toasts, we should rather create a separate state in Also, I think current approach intermingles See if makes sense and if it passed your tests. Screen.Recording.2025-10-15.at.12.30.40.mov |
This is much better, will go with this. |
logeekal
left a comment
There was a problem hiding this comment.
Desk Tested. Working great. Thanks 🚀 .
|
Starting backport for target branches: 9.2 https://github.com/elastic/kibana/actions/runs/18961300852 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
…on navigation (elastic#239058) ## Summary issue: elastic#237466 This pr changes the way migration service classes call toasts so that they can be dismissed as well when a user navigates to the migration table upon completion. https://github.com/user-attachments/assets/dd47e9b4-6c8e-4749-8ae7-4a71b5b4e237 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co> (cherry picked from commit b622962)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ation on navigation (#239058) (#241397) # Backport This will backport the following commits from `main` to `9.2`: - [[Automatic Migrations] Clear migration completion toast notification on navigation (#239058)](#239058) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-31T02:58:41Z","message":"[Automatic Migrations] Clear migration completion toast notification on navigation (#239058)\n\n## Summary\n\nissue: https://github.com/elastic/kibana/issues/237466\n\nThis pr changes the way migration service classes call toasts so that\nthey can be dismissed as well when a user navigates to the migration\ntable upon completion.\n\n\nhttps://github.com/user-attachments/assets/dd47e9b4-6c8e-4749-8ae7-4a71b5b4e237\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>","sha":"b622962eb1ac479a503ab279f836f2d8029b4cbf","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.2.0","v9.3.0"],"title":"[Automatic Migrations] Clear migration completion toast notification on navigation","number":239058,"url":"https://github.com/elastic/kibana/pull/239058","mergeCommit":{"message":"[Automatic Migrations] Clear migration completion toast notification on navigation (#239058)\n\n## Summary\n\nissue: https://github.com/elastic/kibana/issues/237466\n\nThis pr changes the way migration service classes call toasts so that\nthey can be dismissed as well when a user navigates to the migration\ntable upon completion.\n\n\nhttps://github.com/user-attachments/assets/dd47e9b4-6c8e-4749-8ae7-4a71b5b4e237\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>","sha":"b622962eb1ac479a503ab279f836f2d8029b4cbf"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239058","number":239058,"mergeCommit":{"message":"[Automatic Migrations] Clear migration completion toast notification on navigation (#239058)\n\n## Summary\n\nissue: https://github.com/elastic/kibana/issues/237466\n\nThis pr changes the way migration service classes call toasts so that\nthey can be dismissed as well when a user navigates to the migration\ntable upon completion.\n\n\nhttps://github.com/user-attachments/assets/dd47e9b4-6c8e-4749-8ae7-4a71b5b4e237\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>","sha":"b622962eb1ac479a503ab279f836f2d8029b4cbf"}}]}] BACKPORT--> Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
…on navigation (elastic#239058) ## Summary issue: elastic#237466 This pr changes the way migration service classes call toasts so that they can be dismissed as well when a user navigates to the migration table upon completion. https://github.com/user-attachments/assets/dd47e9b4-6c8e-4749-8ae7-4a71b5b4e237 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
…on navigation (elastic#239058) ## Summary issue: elastic#237466 This pr changes the way migration service classes call toasts so that they can be dismissed as well when a user navigates to the migration table upon completion. https://github.com/user-attachments/assets/dd47e9b4-6c8e-4749-8ae7-4a71b5b4e237 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>

Summary
issue: #237466
This pr changes the way migration service classes call toasts so that they can be dismissed as well when a user navigates to the migration table upon completion.
clear_toast.mov
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.