Skip to content

[8.19] [dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)#238988

Merged
kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine:backport/8.19/pr-238731
Oct 14, 2025
Merged

[8.19] [dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)#238988
kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine:backport/8.19/pr-238731

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…out in the KQL search bar (elastic#238731)

Closes elastic#236288

### Background
elastic#225705 fixed an issue where
controls where getting created with adhoc data views. This fix cause
regression elastic#236288. Instead of
filtering out adhoc data views from dashboard.dataViews$, the fix should
occur in the control group level and ignore adhoc data views when
suggesting the data view when creating a control.

### Test instructions
* install sample web logs and wait until its install - web logs is
expected to be default data view
* install sample flights data set
* create new dashboard
* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT
10`
* click into unified search query bar. Verify typeahead is populated
from `flights` data view.
* Add new control to dashboard. Ensure suggested data view is `Kibana
Sample Data Logs` - meaning the control suggested the default data view
and not the adhoc flights data view from the lens panel.

(cherry picked from commit 01e67c3)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 14, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) October 14, 2025 17:58
@nreese
Copy link
Contributor

nreese commented Oct 14, 2025

/ci

@kibanamachine kibanamachine merged commit 21a3e4f into elastic:8.19 Oct 14, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 563.5KB 563.5KB +24.0B
dashboard 703.5KB 703.5KB -29.0B
total -5.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.7MB 3.7MB +129.0B

History

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants