Conversation
…a regular border is already present
|
Pinging @elastic/eui-team (EUI) |
ThomThomson
left a comment
There was a problem hiding this comment.
Presentation team changes LGTM!
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
jbudz
left a comment
There was a problem hiding this comment.
src/dev/license_checker/config.ts LGTM
PhilippeOberti
left a comment
There was a problem hiding this comment.
LGTM for the @elastic/security-threat-hunting-investigations team
x-pack/platform/test/serverless/functional/test_suites/context/_filters.ts
Show resolved
Hide resolved
|
Sorry for the rebasing mess and pings to unrelated reviewers! 🙈 |
- scopes the check closer to the expected functionality
dmlemeshko
left a comment
There was a problem hiding this comment.
src/platform/test/functional/services/combo_box.ts changes LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @tkajtoch |
AlexGPlay
left a comment
There was a problem hiding this comment.
data discovery changes lgtm
## Summary EUI's new version is breaking the storybook builds, we started to get storybook compilation errors after: #238715
- `@elastic/eui`: `v106.7.0` ⏩ `v107.0.0` - `@elastic/eui-theme-borealis`: `v3.5.0` ⏩ `v3.6.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## Changes - Updated scrollable popovers `ResizableSuggestionsListDiv` of the unified search and `ESQLMenuPopover` to prevent broken "floating border" in dark mode (change to separate scrollable container into a standalone element) | before | after | |---|---| | <img width="634" height="854" alt="Screenshot 2025-10-06 at 19 50 01" src="https://github.com/user-attachments/assets/da141bb5-e478-4218-b5bb-5aff95f089ff" /> | <img width="634" height="854" alt="Screenshot 2025-10-06 at 19 50 15" src="https://github.com/user-attachments/assets/f098ce70-9690-46f3-a988-1ee9b8d78f5e" /> | | <img width="279" height="439" alt="Screenshot 2025-10-06 at 18 54 36" src="https://github.com/user-attachments/assets/7496fd91-542d-44d7-acc0-e6cb2ea23531" /> | <img width="274" height="423" alt="Screenshot 2025-10-06 at 18 57 53" src="https://github.com/user-attachments/assets/4d4aa039-f4c2-4266-ab1f-2f42125f1f84" /> | - Update usages of EUI shadow utils (e.g. `euiShadow()`) that are combined with `border` style to adjust the new automatic "floating border" to prevent duplicate borders - Update map button styles (aligning background color and borders) | before | after | |---|---| | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 21 06" src="https://github.com/user-attachments/assets/02f4fc3d-593d-4d30-bf67-3dd70960e074" /> | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 15 50" src="https://github.com/user-attachments/assets/0072d2c1-d47b-4014-944a-682f036937b5" /> | | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 21 27" src="https://github.com/user-attachments/assets/4e639428-43e6-4f39-8f9b-d873549508e8" /> | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 16 06" src="https://github.com/user-attachments/assets/a35760ec-1939-459e-b463-6b533a354352" /> | ## Package updates ## [`v107.0.0`](https://github.com/elastic/eui/releases/v107.0.0) - Added new shadow tokens ([elastic#9088](elastic/eui#9088)) - `shadows.colors.base` - `shadows.xs` - `shadows.s` - `shadows.m` - `shadows.l` - `shadows.xl` - `shadows.flat` - `shadows.hover.base` - `shadows.hover.xl` - Updated shadow utility functions to return new tokens ([elastic#9088](elastic/eui#9088)) - `euiShadow` - `euiShadowXSmall` - `euiShadowSmall` - `euiShadowMedium` - `euiShadowLarge` - `euiShadowXLarge` - `euiShadowFlat` - `euiSlightShadowHover` - Added shadow hover utility `euiShadowHover` ([elastic#9088](elastic/eui#9088)) **Deprecations** - Deprecated `euiShadowFlat` and `useEuiShadowFlat` - use `euiShadow`/ `useEuiShadow` (size `xs`) or `euiShadowXSmall` instead ([elastic#9088](elastic/eui#9088)) - Deprecated `euiSlightShadowHover` and `useEuiSlightShadowHover` - use `euiShadowHover` / `useEuiShadowHover` instead ([elastic#9088](elastic/eui#9088)) **Breaking changes** - Updated shadow utility functions (e.g. `euiShadow`) to apply a floating border style in dark mode. This may lead to visual issues with double borders in dark mode when a regular `border` styling is applied. - Use the `options.border` argument on the utils to adjust or remove the floating border as needed. ([elastic#9088](elastic/eui#9088)) ### `@elastic/eui-theme-borealis` ## [`v3.6.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v360) - Added new shadow tokens ([elastic#9088](elastic/eui#9088)) - `shadows.colors.base` - `shadows.xs` - `shadows.s` - `shadows.m` - `shadows.l` - `shadows.xl` - `shadows.flat` - `shadows.hover.base` - `shadows.hover.xl` --------- Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
## Summary EUI's new version is breaking the storybook builds, we started to get storybook compilation errors after: elastic#238715
- `@elastic/eui`: `v106.7.0` ⏩ `v107.0.0` - `@elastic/eui-theme-borealis`: `v3.5.0` ⏩ `v3.6.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## Changes - Updated scrollable popovers `ResizableSuggestionsListDiv` of the unified search and `ESQLMenuPopover` to prevent broken "floating border" in dark mode (change to separate scrollable container into a standalone element) | before | after | |---|---| | <img width="634" height="854" alt="Screenshot 2025-10-06 at 19 50 01" src="https://github.com/user-attachments/assets/da141bb5-e478-4218-b5bb-5aff95f089ff" /> | <img width="634" height="854" alt="Screenshot 2025-10-06 at 19 50 15" src="https://github.com/user-attachments/assets/f098ce70-9690-46f3-a988-1ee9b8d78f5e" /> | | <img width="279" height="439" alt="Screenshot 2025-10-06 at 18 54 36" src="https://github.com/user-attachments/assets/7496fd91-542d-44d7-acc0-e6cb2ea23531" /> | <img width="274" height="423" alt="Screenshot 2025-10-06 at 18 57 53" src="https://github.com/user-attachments/assets/4d4aa039-f4c2-4266-ab1f-2f42125f1f84" /> | - Update usages of EUI shadow utils (e.g. `euiShadow()`) that are combined with `border` style to adjust the new automatic "floating border" to prevent duplicate borders - Update map button styles (aligning background color and borders) | before | after | |---|---| | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 21 06" src="https://github.com/user-attachments/assets/02f4fc3d-593d-4d30-bf67-3dd70960e074" /> | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 15 50" src="https://github.com/user-attachments/assets/0072d2c1-d47b-4014-944a-682f036937b5" /> | | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 21 27" src="https://github.com/user-attachments/assets/4e639428-43e6-4f39-8f9b-d873549508e8" /> | <img width="66" height="254" alt="Screenshot 2025-10-14 at 08 16 06" src="https://github.com/user-attachments/assets/a35760ec-1939-459e-b463-6b533a354352" /> | ## Package updates ## [`v107.0.0`](https://github.com/elastic/eui/releases/v107.0.0) - Added new shadow tokens ([elastic#9088](elastic/eui#9088)) - `shadows.colors.base` - `shadows.xs` - `shadows.s` - `shadows.m` - `shadows.l` - `shadows.xl` - `shadows.flat` - `shadows.hover.base` - `shadows.hover.xl` - Updated shadow utility functions to return new tokens ([elastic#9088](elastic/eui#9088)) - `euiShadow` - `euiShadowXSmall` - `euiShadowSmall` - `euiShadowMedium` - `euiShadowLarge` - `euiShadowXLarge` - `euiShadowFlat` - `euiSlightShadowHover` - Added shadow hover utility `euiShadowHover` ([elastic#9088](elastic/eui#9088)) **Deprecations** - Deprecated `euiShadowFlat` and `useEuiShadowFlat` - use `euiShadow`/ `useEuiShadow` (size `xs`) or `euiShadowXSmall` instead ([elastic#9088](elastic/eui#9088)) - Deprecated `euiSlightShadowHover` and `useEuiSlightShadowHover` - use `euiShadowHover` / `useEuiShadowHover` instead ([elastic#9088](elastic/eui#9088)) **Breaking changes** - Updated shadow utility functions (e.g. `euiShadow`) to apply a floating border style in dark mode. This may lead to visual issues with double borders in dark mode when a regular `border` styling is applied. - Use the `options.border` argument on the utils to adjust or remove the floating border as needed. ([elastic#9088](elastic/eui#9088)) ### `@elastic/eui-theme-borealis` ## [`v3.6.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v360) - Added new shadow tokens ([elastic#9088](elastic/eui#9088)) - `shadows.colors.base` - `shadows.xs` - `shadows.s` - `shadows.m` - `shadows.l` - `shadows.xl` - `shadows.flat` - `shadows.hover.base` - `shadows.hover.xl` --------- Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
## Summary EUI's new version is breaking the storybook builds, we started to get storybook compilation errors after: elastic#238715
@elastic/eui:v106.7.0⏩v107.0.0@elastic/eui-theme-borealis:v3.5.0⏩v3.6.0Questions? Please see our Kibana upgrade FAQ.
Changes
ResizableSuggestionsListDivof the unified search andESQLMenuPopoverto prevent broken "floating border" in dark mode (change to separate scrollable container into a standalone element)Update usages of EUI shadow utils (e.g.
euiShadow()) that are combined withborderstyle to adjust the new automatic "floating border" to prevent duplicate bordersUpdate map button styles (aligning background color and borders)
Package updates
v107.0.0shadows.colors.baseshadows.xsshadows.sshadows.mshadows.lshadows.xlshadows.flatshadows.hover.baseshadows.hover.xleuiShadoweuiShadowXSmalleuiShadowSmalleuiShadowMediumeuiShadowLargeeuiShadowXLargeeuiShadowFlateuiSlightShadowHovereuiShadowHover(#9088)Deprecations
euiShadowFlatanduseEuiShadowFlat- useeuiShadow/useEuiShadow(sizexs) oreuiShadowXSmallinstead (#9088)euiSlightShadowHoveranduseEuiSlightShadowHover- useeuiShadowHover/useEuiShadowHoverinstead (#9088)Breaking changes
euiShadow) to apply a floating border style in dark mode. This may lead to visual issues with double borders in dark mode when a regularborderstyling is applied. - Use theoptions.borderargument on the utils to adjust or remove the floating border as needed. (#9088)@elastic/eui-theme-borealisv3.6.0shadows.colors.baseshadows.xsshadows.sshadows.mshadows.lshadows.xlshadows.flatshadows.hover.baseshadows.hover.xl